Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5269 closed defect (invalid)

[CLA] [patch] dojo.data related: enhance setRow() to allow using a dojo.data item and add getRowByIdentity()

Reported by: wolfram Owned by: benschell
Priority: high Milestone: 1.1
Component: DojoX Grid Version: 1.0
Keywords: dojo.data Cc: Jared Jurkiewicz
Blocked By: Blocking:

Description

The grid model for dojo.data is missing some functionality to effectively work with the dojo.data stores. I was using it with QueryReadStore?, to fill a grid on demand. While working with it I fixed the model class a bit. I hope that is the way its meant.

Attachments (1)

patch5269.diff (4.7 KB) - added by wolfram 12 years ago.
oops forgot an adjustment

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by wolfram

Cc: Jared Jurkiewicz added

Jaredj may you look at this too, please? It seems that some of your fixes in grid/_data/models.js are along the lines of this patch. thx

Wolfram

comment:2 Changed 12 years ago by wolfram

Keywords: dojo.data added
Summary: [CLA] [patch] Grid enhancements for working with dojo.data[CLA] [patch] dojo.data related: enhance setRow() to allow using a dojo.data item and add getRowByIdentity()

adjusted patch to still work after jaredj changed the grid-model in r12038. This patch additionally provides the following features:

  • setRow(dojo-data-item, index) - a method to allow setting a row by using a dojo.data-item (a possible case when working with dojo.data-stores)
  • getRowByIdentity() allow retreiving a row by an items identity

therefore i had to extract some functionality into setRow(). And there are a couple open issues, if jaredj could look at them that would be great!

Wolfram

Changed 12 years ago by wolfram

Attachment: patch5269.diff added

oops forgot an adjustment

comment:3 Changed 12 years ago by Jared Jurkiewicz

A co-worker of mine is working on grid problems. I've forwarded this tracker to him so he can see if he's already resolved some of them

comment:4 Changed 12 years ago by dylan

Milestone: 1.1

comment:5 Changed 12 years ago by sorvell

Milestone: 1.11.2
Owner: changed from sorvell to Jared Jurkiewicz

Reassigning this to Jared since he was going to follow up.

Suggest assigning to Alex if necessary since he worked on the grid dojo.data implementation.

Thanks guys.

comment:6 Changed 12 years ago by Jared Jurkiewicz

Owner: changed from Jared Jurkiewicz to benshell

comment:7 Changed 12 years ago by Jared Jurkiewicz

Owner: changed from benshell to benschell

comment:8 Changed 12 years ago by wolfram

Resolution: invalid
Status: newclosed

had become obsolete with latest changes in grid+queryreadstore

comment:9 Changed 12 years ago by wolfram

Milestone: 1.21.1
Note: See TracTickets for help on using tickets.