Opened 12 years ago

Closed 11 years ago

#5234 closed enhancement (fixed)

Lightbox large image support

Reported by: guest Owned by: dante
Priority: high Milestone: 1.1
Component: Dojox Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

See forum discussion.

The Lightbox widget breaks when used with images larger than the browser window size. It should probably either resize the image to fit the dialog window, or put the image in a scrollable div.

Change History (4)

comment:1 Changed 12 years ago by dante

Milestone: 1.1
Owner: changed from Tom Trenka to dante
Status: newassigned

comment:2 Changed 11 years ago by dante

Milestone: 1.11.2

I've started to do this, and really it adds a lot of code. It also doesn't work yet in some cases (most notably a browser that starts with I and ends in nternet Explorer). The reason it did work so easily is because no styling is set on any image, allowing the one image in the surface to resize each time reloaded. there is no way to "unstyle" it once you've adjusted it for being oversized, so all the remaining images in the lightbox will scale to the aspect ratio of the one that is styled.

tempted to mark this as wontfix. I don't like the idea of a scrollable div personally.

comment:3 Changed 11 years ago by dante

Milestone: 1.21.1

okay I lied I found a solution I like.

comment:4 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [12168]) fixes #5578 and fixes #5234 - if image larger than viewport, scale down maintaing aspect ratio. also onerror cleanup to remove redundant disconnect() connect() sequence, size optimizations (_t) and finish moving out available animations to semi permenant instance vars.

thanks nikolai for making me finish this old patch I had otherwise abandoned.

Note: See TracTickets for help on using tickets.