Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5232 closed defect (fixed)

[DojoX] [PATCH] [CLA] Non-active resizing for widgets in ResizeHandle

Reported by: BlueFire Owned by: dante
Priority: high Milestone: 1.1
Component: Dojox Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

This was done for the ResizeHandle? to do non-active resizing in conjunction with FloatingPane?. To test the functionality use the FP test cases instead of the RH test cases.

A single top-level resize helper is generated and reused for all resize operations. For it to be always displayed on top, it has to be a top-level div and it receives a high z-index (1000) via its CSS class.

CLA on file: UPW Innovative IT-Lösungen GmbH

Attachments (1)

dojoxResizeHandle_20071124.patch (5.8 KB) - added by BlueFire 12 years ago.
Patch against rev 11621

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by BlueFire

Re-did the patch. Tested: FF2 (Win), IE7, Safari 3 (OS X)

Previous version had very very weird effects like selection of text during resizing in IE7. Cancelling the resizing event earlier removed those problems for me.

Minor issue: while the resize-box is exactly overlaid on the original element in IE7 and Safari3, in FF it seems to be a pixel off. Probably this is due to the borders width being included differently. I assume there is some elegant way to solve that using a dojo function, but I don't know which.

Minor issue: In FF when the non-active resizing is used with an animation, there seems to be a moment of nothing before the animation starts. In Safari3 and IE7 it starts immediately.

Changed 12 years ago by BlueFire

Patch against rev 11621

comment:2 Changed 12 years ago by BlueFire

Updated the patch. Tested: FF2 (Win), IE7, Safari 3 (OS X)

Forget the second minor issue from before. Originally the ResizeHandle? simply didn't cancel the resize event which led to strange effects in IE. Then I moved the cancel to a point too early which caused problems in FF. Now the canceling happens always when leaving _updateSizing() which makes both browsers happy.

comment:3 Changed 12 years ago by dante

Milestone: 1.0.21.1
Status: newassigned

comment:4 Changed 12 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [11624]) fixes #5219 - destroy contents as well as pane on close. fixes #5231 - patch from BlueFire? allowing the child of a floatingpane to be a LayoutWidget? and size accordingly, and fixes #5232 - another patch from BlueFire? to make resize handle use a single 'rubberband' for virtual sizing.

comment:5 Changed 12 years ago by bill

Component: GeneralDojox
Note: See TracTickets for help on using tickets.