Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#523 closed defect (fixed)

ToolbarItem fails to handle 'selected' attribute in markup-based construction

Reported by: laurie@… Owned by: liucougar
Priority: high Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

If you create a toolbar toggle item using markup and set it to be selected, it wont be. For example, using the following markup:

<span dojoType="ToolbarButton" toggleItem="true" selected="true"></span>

results in a call to ToolbarItem?.setSelected(true,undefined,undefined). But because this call occurs before setToggleItem() is called, it simply returns without doing anything.

The solution is probably to make setSelected simply update _selected and defer the other logic in the method to rendering time. Unfortunately, that would affect the semantics of the onSelect/onDeselect/onChangeSelect events for all ToolbarItem? sub-classes...

Change History (5)

comment:1 Changed 14 years ago by alex

Milestone: 0.3release
Owner: changed from anonymous to alex
Status: newassigned

comment:2 Changed 14 years ago by alex

Milestone: 0.3release0.4
Owner: alex deleted
Status: assignednew

comment:3 Changed 13 years ago by dylan

Owner: set to liucougar

comment:4 Changed 13 years ago by liucougar

Resolution: fixed
Status: newclosed

this should not be a problem for the new editor2 now

closed

comment:5 Changed 13 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.