#5222 closed defect (fixed)
dijit.Form.CheckBox onChange method problem
| Reported by: | guest | Owned by: | Douglas Hays |
|---|---|---|---|
| Priority: | high | Milestone: | 1.1 |
| Component: | Dijit - Form | Version: | 1.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
Hi,
I found a problem with the onchange method of dijit.Form.CheckBox? and RadioButton?.
When the widgets are created programmatically the onchange method is fired twice. I didn't test it with markup.
Here under find a code that demonstrate the problem. This occurs with FF, IE6 and IE7, under Windows XP sp2.
Dojo version is 0.9.0dev (11363) major=0 minor=9 patch=0 flag=dev revision=11363
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=windows-1250">
<meta name="generator" content="PSPad editor, www.pspad.com">
<title></title>
</head>
<script type="text/javascript"
src="../js/dojo/dojo/dojo.js"
djConfig="isDebug: false, parseOnLoad: true, usePlainJson : true, preventBackButtonFix: false"
></script>
<script type="text/javascript">
dojo.require("dijit.form.CheckBox");
dojo.addOnLoad(init);
function init() {
checkBox1 = new dijit.form.CheckBox({
id : 'id1'
,value : '1'
,onChange : onChangeCheckBox
}, dojo.byId("myDiv"));
checkBox2 = new dijit.form.RadioButton({
id : 'id2'
,name : "radio"
,value : '2'
,onChange : onChangeCheckBox2
}, dojo.byId("myDiv2"));
checkBox3 = new dijit.form.RadioButton({
id : 'id3'
,name : "radio"
,value : '3'
,onChange : onChangeCheckBox2
}, dojo.byId("myDiv3"));
console.log("before setchecked checkbox1")
checkBox1.setChecked(true);
console.log("before setchecked checkbox2")
checkBox2.setChecked(true);
console.log("before setchecked checkbox3")
checkBox3.setChecked(true);
}
function onChangeCheckBox(a) {
console.log("onChangeCheckBox", a, this, this.checked);
}
function onChangeCheckBox2(a) {
console.log("onChangeCheckBox2", a, this, this.checked);
}
</script>
<body>
<div id="myDiv"> </div>
<div id="myDiv2"> </div>
<div id="myDiv3"> </div>
</body>
</html>
Best regards
Roger [email protected]…
Change History (4)
comment:1 Changed 12 years ago by
| Component: | General → Dijit |
|---|---|
| Description: | modified (diff) |
| Milestone: | → 1.1 |
| Owner: | changed from anonymous to Douglas Hays |
comment:2 Changed 12 years ago by
The problem is that ToggleButton? setChecked calls onChange directly w/o checking for actual change. Everything should be going thru setValue.
comment:3 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [11982]) Fixes #5222 !strict. Split out the special value processing in _FormWidget and subclassed it into _FormValueWidget so that Button and TextBox? could inherit from different classes, allowing value to be treated like a simple string attribute for Buttons/checkboxes and as complex objects for input widgets (dates/times/currency/etc). Deprecated setChecked and setValue for Button widgets (and subclasses) for the new setAttribute method for all simple attributes. Removed onChange(string) that was being called for Buttons/checkboxes when the value attribute was changed. Only onChange(boolean) should be called for checkboxes.
comment:4 Changed 9 years ago by
| Component: | Dijit → Dijit - Form |
|---|
Hmm, it shouldn't be getting called at all (on instantiation). Doug, can you fix?