#5198 closed defect (fixed)
Can't edit InlineEditBox of FilteringSelect
Reported by: | haysmark | Owned by: | bill |
---|---|---|---|
Priority: | blocker | Milestone: | 1.0.2 |
Component: | Dijit - Form | Version: | 1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
In FF or Safari:
- Go to http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/themes/themeTester.html
- Scroll down to the last InlineEditBox? with Indiana.
- Click Indiana.
There is a flicker as the InlineEditBox? opens and closes.
This seems to be a strange variation of http://trac.dojotoolkit.org/ticket/3997 that affects the exact opposite set of browsers.
Change History (10)
comment:1 Changed 13 years ago by
Owner: | set to bill |
---|---|
Priority: | normal → highest |
severity: | normal → major |
comment:2 Changed 13 years ago by
comment:3 Changed 13 years ago by
Milestone: | 1.0.1 → 1.0.2 |
---|
comment:4 Changed 13 years ago by
Problem is this code, which assumes (incorrectly) that onChange will be fired synchronously in all cases, before the connect call:
(this.editWidget.setDisplayedValue||this.editWidget.setValue).call(this.editWidget, this.value); ... this.connect(this.editWidget, "onChange", "_onChange");
For ComboBox/ItemFileReadStore? with an href, there's a delay loading in the data from the href which causes the onChange event to fire after the connect call.
Will fix tomorrow.
comment:5 Changed 13 years ago by
Summary: | Can't edit InlineEditBox in themeTester → Can't edit InlineEditBox of FilteringSelect |
---|
comment:6 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [11685]) Fixes #5198 on trunk: can't edit InlineEditBox? of FilteringSelect?, by handling case where the onChange notification is asynchronous from the setValue call() Leaves open issue that DateTextBox? now requires an extra click to close, since setDisplayedValue() on DateTextBox/TimeTextBox? doesn't generate an onChange event at all.
comment:7 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
needs to be merged to 1.0.2
comment:8 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [11686]) Fixes #5198 on 1.0 branch: can't edit InlineEditBox? of FilteringSelect?, by handling case where the onChange notification is asynchronous from the setValue call() Leaves open issue that DateTextBox? now requires an extra click to close, since setDisplayedValue() on DateTextBox/TimeTextBox? doesn't generate an onChange event at all.
comment:10 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
Folks, 1.0.1 is done. Let's shoot for 1.0.2.