Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#5198 closed defect (fixed)

Can't edit InlineEditBox of FilteringSelect

Reported by: haysmark Owned by: bill
Priority: blocker Milestone: 1.0.2
Component: Dijit - Form Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

In FF or Safari:

  1. Go to http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/themes/themeTester.html
  2. Scroll down to the last InlineEditBox? with Indiana.
  3. Click Indiana.

There is a flicker as the InlineEditBox? opens and closes.

This seems to be a strange variation of http://trac.dojotoolkit.org/ticket/3997 that affects the exact opposite set of browsers.

Change History (10)

comment:1 Changed 12 years ago by Douglas Hays

Owner: set to bill
Priority: normalhighest
severity: normalmajor

comment:2 Changed 12 years ago by Adam Peller

Folks, 1.0.1 is done. Let's shoot for 1.0.2.

comment:3 Changed 12 years ago by Adam Peller

Milestone: 1.0.11.0.2

comment:4 Changed 12 years ago by bill

Problem is this code, which assumes (incorrectly) that onChange will be fired synchronously in all cases, before the connect call:

(this.editWidget.setDisplayedValue||this.editWidget.setValue).call(this.editWidget, this.value);
...
this.connect(this.editWidget, "onChange", "_onChange");

For ComboBox/ItemFileReadStore? with an href, there's a delay loading in the data from the href which causes the onChange event to fire after the connect call.

Will fix tomorrow.

comment:5 Changed 12 years ago by bill

Summary: Can't edit InlineEditBox in themeTesterCan't edit InlineEditBox of FilteringSelect

comment:6 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [11685]) Fixes #5198 on trunk: can't edit InlineEditBox? of FilteringSelect?, by handling case where the onChange notification is asynchronous from the setValue call() Leaves open issue that DateTextBox? now requires an extra click to close, since setDisplayedValue() on DateTextBox/TimeTextBox? doesn't generate an onChange event at all.

comment:7 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: closedreopened

needs to be merged to 1.0.2

comment:8 Changed 12 years ago by bill

Resolution: fixed
Status: reopenedclosed

(In [11686]) Fixes #5198 on 1.0 branch: can't edit InlineEditBox? of FilteringSelect?, by handling case where the onChange notification is asynchronous from the setValue call() Leaves open issue that DateTextBox? now requires an extra click to close, since setDisplayedValue() on DateTextBox/TimeTextBox? doesn't generate an onChange event at all.

comment:9 Changed 12 years ago by bill

See related bug #5304.

comment:10 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.