Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5183 closed defect (fixed)

LayoutContainer layout messed up on Safari3/Webkit

Reported by: bill Owned by:
Priority: high Milestone: 1.0.1
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Attachments (1)

parser.patch (1.9 KB) - added by bill 12 years ago.
possible patch to parser to wait until CSS finishes loading before running (but according to phiggins the CSS file may be loaded in stages so should really trigger off the last entry in dijit.css... and that may still not be good enough...)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by Adam Peller

Bill, what exactly are you seeing?

On Windows/Safari? 3, I think I actually see an improvement in 1.0.1rc4, but both seem broken:

In 1.0.0, the first layout (only) is messed up (top and bottom are too narrow, right is missing). In 1.0.1rc4, all layouts look ok.

In both 1.0.0 and 1.0.1rc4, the combo dropdowns fail in all but the first layoutcontainer.

comment:2 Changed 12 years ago by bill

I'm seeing that the first layout (only) is messed up (top and bottom are too narrow, right is missing). Now seems to happen intermittently in either 1.0 or 1.0.1rc4; a race condition.

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [11591]) Fixes #5183 on 1.0 branch: Workaround race condition where widgets are parsed before CSS finishes loading: moved @include of CSS before load of dojo.js. We may want to implement a more robust solution later, using a timer to test when the CSS has finished loading, but checking this in for now.

comment:4 Changed 12 years ago by bill

(In [11592]) Fixes #5183 on trunk: Workaround race condition where widgets are parsed before CSS finishes loading: moved @include of CSS before load of dojo.js. We may want to implement a more robust solution later, using a timer to test when the CSS has finished loading, but checking this in for now.

comment:5 Changed 12 years ago by bill

(In [11593]) Fixes #5183 on trunk: Workaround race condition where widgets are parsed before CSS finishes loading: moved @include of CSS before load of dojo.js. We may want to implement a more robust solution later, using a timer to test when the CSS has finished loading, but checking this in for now.

Changed 12 years ago by bill

Attachment: parser.patch added

possible patch to parser to wait until CSS finishes loading before running (but according to phiggins the CSS file may be loaded in stages so should really trigger off the last entry in dijit.css... and that may still not be good enough...)

Note: See TracTickets for help on using tickets.