Opened 12 years ago

Closed 11 years ago

#5180 closed enhancement (fixed)

Move Gears detection out of Dojo Base

Reported by: James Burke Owned by: James Burke
Priority: high Milestone: 1.2
Component: BuildSystem Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by James Burke)

Gears detection should be a Dojo Core module, but not part of Dojo Base. Cleared it on dojo-contributors.

Change History (8)

comment:1 Changed 12 years ago by James Burke

Type: defectenhancement

comment:3 Changed 12 years ago by Eugene Lazutkin

Q: does it need to be in the core in the first place? E.g., in gfx the detection code is in a file, which belongs to gfx --- if you don't use gfx, you don't pay for it, which seems to be not the case for google gears.

comment:4 Changed 12 years ago by James Burke

I'm all for moving it out of base. I'll ask Alex if it needs to be in base.

comment:5 Changed 12 years ago by James Burke

Milestone: 1.11.2

I plan on moving the gears code out of base and into a Core dojo.gears module. I floated the idea on dojo-contributors, and the response was positive. However, I really need to test the dojox.off code when I do that change. I have not used it or gears before, so I am not likely to get this done before the beta build for 1.1. It would have been nice to save some bytes for base, but it will have to wait.

comment:6 Changed 11 years ago by James Burke

Description: modified (diff)
Summary: Build option to exclude Google Gears detectionMove Google Gears out of Dojo Base

comment:7 Changed 11 years ago by James Burke

Summary: Move Google Gears out of Dojo BaseMove Gears detection out of Dojo Base

comment:8 Changed 11 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [14293]) Fixes #5180: move gears detection out of Dojo Base. Now in a dojo.gears module. Tested change in FF3 with Gears, using dojox.off and dojox.storage demos. \!strict

Note: See TracTickets for help on using tickets.