Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#5166 closed defect (fixed)

dijit.form.Button.setLabel can result in display:none

Reported by: gregwilkins Owned by: Douglas Hays
Priority: high Milestone: 1.1
Component: Dijit - Form Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Button.setLabel on mozilla sets the style.display to none and then uses a timer to re-establish the correct value.

However, if setLabel is called twice in a short period of time, then the style is left as display:none

Attachments (1)

button.patch (1.0 KB) - added by gregwilkins 12 years ago.
updated fix that uses hitch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by gregwilkins

Owner: changed from anonymous to gregwilkins

just testing a fix..

Changed 12 years ago by gregwilkins

Attachment: button.patch added

updated fix that uses hitch

comment:2 Changed 12 years ago by bill

Component: GeneralDijit
Milestone: 1.1
Owner: changed from gregwilkins to Douglas Hays

OK, Greg is a committer but since you are posting the patch, I guess you wanted someone else to look at it? So assigning to Doug.

comment:3 Changed 12 years ago by Greg Wilkins

Resolution: fixed
Status: newclosed

(In [11540]) fixes #5166 allow rapid setLabel calls

comment:4 Changed 12 years ago by gregwilkins

Bill,

yes I did want somebody else to check it, but I did that via #irc thanks. So I've checked in now after fixing from their feedback.

So what is the process of moving patches from trunk to branches? Anything else I need to do?

comment:5 Changed 12 years ago by bill

OIC. Yes, patches are complicated, you need to recheck in your code to the files in the branches/1.0 svn directory (and to test them).

comment:6 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.