Opened 13 years ago

Closed 13 years ago

#5160 closed defect (fixed)

dojo.Declaration does event connections on the prototype functions

Reported by: Neil Roberts Owned by: alex
Priority: blocker Milestone: 1.0.1
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

If we've created a class using a type="dojo/connect" script block, the even is fired across all instances of the class. 

var wcp = dojo.getObject(this.widgetClass).prototype;
scripts.forEach(function(s){
  var event = s.getAttribute("event");
  dojo.connect(wcp, event || "postscript", null, dojo.parser._functionFromScript(s));
});

Change History (5)

comment:1 Changed 13 years ago by Neil Roberts

Owner: changed from slightlyoff to alex

comment:2 Changed 13 years ago by Adam Peller

Do we hold up 1.0.1 for this, or should this be for 1.0.2?

comment:3 Changed 13 years ago by alex

Status: new → assigned

we absolutely need this for 1.0.1

comment:4 Changed 13 years ago by alex

(In [11541]) make sure that <script type="dojo/connect"> works correctly. Refs #5160

comment:5 Changed 13 years ago by Neil Roberts

Resolution: → fixed
Status: assigned → closed

(In [11542]) Fixes #5160. Merge r11541 into 1.0 branch.

Note: See TracTickets for help on using tickets.