Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#5155 closed defect (fixed)

QueryReadStore does not implement dojo.data.api.Identity

Reported by: guest Owned by: Jared Jurkiewicz
Priority: high Milestone:
Component: DojoX Data Version: 1.0
Keywords: Identity QueryReadStore Cc:
Blocked By: Blocking:

Description

It looks like the QueryReadStore? has all the dojo.data.api.Identity methods implemented but it doesn't return dojo.data.api.Identity as a feature on getFeature()

Shouldn't getFeatures() be this?: 

	getFeatures: function()
	{
	  return this._features;
	},

Attachments (1)

dojox.data.QueryReadStore_20071126.patch​ (1016 bytes) - added by Jared Jurkiewicz 14 years ago.
Minor patch to fix return of getFeatures.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 14 years ago by Jared Jurkiewicz

Yes, it should. Will check in a fix next week, when back from Thanksgiving vacation and dealing with relatives.

comment:2 Changed 14 years ago by Jared Jurkiewicz

This should also have a UT test that verifies the features supported. That will also be added next week.

Changed 14 years ago by Jared Jurkiewicz

Attachment: dojox.data.QueryReadStore_20071126.patch​ added

Minor patch to fix return of getFeatures.

comment:3 Changed 14 years ago by Jared Jurkiewicz

Tested on:

FireFox? 2.0.0.9 Safari B3 IE 6 IE 7 Firefox 1.5.0.12 Opera 9.2 Seamonkey 1.1.2

comment:4 Changed 14 years ago by Jared Jurkiewicz

Resolution: → fixed
Status: new → closed

(In [11631]) Minor fix to QueryReadStore?. fixes #5155

comment:5 Changed 14 years ago by Jared Jurkiewicz

(In [11632]) Commiting patch to trunk as well. refs #5155

Note: See TracTickets for help on using tickets.