Opened 12 years ago

Closed 9 years ago

Last modified 9 years ago

#5132 closed defect (wontfix)

[patch] [ccla] ProgressBar: no visible focus indicator when at min or max

Reported by: ptbrunet Owned by: Becky Gibson
Priority: high Milestone: 1.4
Component: Accessibility Version: 0.9
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

Go to http://archive.dojotoolkit.org/dojo-2007-11-05/dojotoolkit/dijit/tests/test_ProgressBar.html and notice that there is no focus indicator when the progress bar is at min or max. (And it's hard to see when it is visible.)

Attachments (2)

5132.patch (958 bytes) - added by Becky Gibson 9 years ago.
5132_useme.patch (736 bytes) - added by Becky 9 years ago.
Firefox only solution

Download all attachments as: .zip

Change History (14)

comment:1 Changed 12 years ago by Becky Gibson

Component: DijitAccessibility
Owner: set to Becky Gibson

Focus could use work in high contrast mode. Perhaps change the border style when focus is actually on the control.

comment:2 Changed 11 years ago by Becky Gibson

Milestone: 1.11.2

comment:3 Changed 11 years ago by Becky Gibson

Milestone: 1.21.3

comment:4 Changed 11 years ago by bill

Milestone: 1.31.5

Changed 9 years ago by Becky Gibson

Attachment: 5132.patch added

comment:5 Changed 9 years ago by Becky Gibson

Cc: Douglas Hays added; brunet@… removed
Milestone: 1.51.4
Priority: normalhigh

Moved to 1.4 and high priority so will get reviewed for possible inclusion in 1.4. I removed the overflow:hidden on .dijitProgressBarEmpty. Although, it is needed for IE6 so I created an IE6 specific style to add it back. I tested on Win XP with IE6, FF3.5.5, IE7, IE 8 in standard and high contrast mode. I also changed the font size as I was a bit worried about what removing the overflow might do (but it is still on .dijitProgressBarFull. This change makes focus more visible in Firefox and doesn't seem to impact the focus rectangle on IE. Would like to include this in 1.4.

comment:6 Changed 9 years ago by bill

Milestone: 1.41.5
Summary: Progress Bar: no visible focus indicator when at min or maxProgressBar: no visible focus indicator when at min or max

It looks pretty safe but also this ticket has been open for two years so I don't think it's urgent to put into 1.4.

comment:7 Changed 9 years ago by Adam Peller

Milestone: 1.51.4.1

Changed 9 years ago by Becky

Attachment: 5132_useme.patch added

Firefox only solution

comment:8 Changed 9 years ago by Becky

Summary: ProgressBar: no visible focus indicator when at min or max[patch] [ccla] ProgressBar: no visible focus indicator when at min or max

Created a new patch to change the border style on focus. Removing the overflow:hidden in the previous patch allowed the background image to overflow the height of the bar in some cases so I could use that approach. Created a FF only :focus class since IE does a good job of drawing focus without a separate class. It does change the look of the progress bar when it gets focus in FF so would like a review before I check in for 1.4.1 and trunk.

comment:9 Changed 9 years ago by bill

It looks good. You might want to use .dj_moz rather than .dj_ff3 so that it applies to other mozilla based browsers. In theory it's needed there too.

I'm not sure why we need to focus ProgressBar at all though, given that the user can't interact with it. I guess it's so a screen reader will read the value, although that seems like a workaround to a screen reader bug at the expense of everyone else using keyboard.

comment:10 Changed 9 years ago by Becky

Since the progress bar is in the tab order, (yes, for the benefit of the screen reader or low vision user) the user needs to have some idea that focus is on it. Otherwise it is very confusing when tabbing through the page. I'll check with other accessibility folks to see if there is another solution.

comment:11 Changed 9 years ago by Becky Gibson

Resolution: wontfix
Status: newclosed

The consensus from the accessibility community is that the progress bar should not receive focus. I'll close this ticket and open a new one #10591

comment:12 Changed 9 years ago by Adam Peller

Milestone: 1.4.11.4
Note: See TracTickets for help on using tickets.