[patch] [ccla] ProgressBar: no visible focus indicator when at min or max

[ptbrunet]

Go to ​http://archive.dojotoolkit.org/dojo-2007-11-05/dojotoolkit/dijit/tests/test_ProgressBar.html and notice that there is no focus indicator when the progress bar is at min or max. (And it's hard to see when it is visible.)

[Becky Gibson]

Focus could use work in high contrast mode. Perhaps change the border style when focus is actually on the control.

[Becky Gibson]

Moved to 1.4 and high priority so will get reviewed for possible inclusion in 1.4. I removed the overflow:hidden on .dijitProgressBarEmpty. Although, it is needed for IE6 so I created an IE6 specific style to add it back. I tested on Win XP with IE6, FF3.5.5, IE7, IE 8 in standard and high contrast mode. I also changed the font size as I was a bit worried about what removing the overflow might do (but it is still on .dijitProgressBarFull. This change makes focus more visible in Firefox and doesn't seem to impact the focus rectangle on IE. Would like to include this in 1.4.

[bill]

It looks pretty safe but also this ticket has been open for two years so I don't think it's urgent to put into 1.4.

[Becky]

Firefox only solution

[Becky]

Created a new patch to change the border style on focus. Removing the overflow:hidden in the previous patch allowed the background image to overflow the height of the bar in some cases so I could use that approach. Created a FF only :focus class since IE does a good job of drawing focus without a separate class. It does change the look of the progress bar when it gets focus in FF so would like a review before I check in for 1.4.1 and trunk.

[bill]

It looks good. You might want to use .dj_moz rather than .dj_ff3 so that it applies to other mozilla based browsers. In theory it's needed there too.

I'm not sure why we need to focus ProgressBar at all though, given that the user can't interact with it. I guess it's so a screen reader will read the value, although that seems like a workaround to a screen reader bug at the expense of everyone else using keyboard.

[Becky]

Since the progress bar is in the tab order, (yes, for the benefit of the screen reader or low vision user) the user needs to have some idea that focus is on it. Otherwise it is very confusing when tabbing through the page. I'll check with other accessibility folks to see if there is another solution.

[Becky Gibson]

The consensus from the accessibility community is that the progress bar should not receive focus. I'll close this ticket and open a new one #10591