Opened 12 years ago

Closed 12 years ago

Last modified 10 years ago

#5131 closed defect (fixed)

isDebug:true iframe dojo inside isDebug:false main page dojo fails (IE)

Reported by: bill Owned by: James Burke
Priority: high Milestone: 1.0.1
Component: Core Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

This was the root cause of #5070. The main drupal page included dojo with isDebug: false, and then had an iframe which included dojo.js with isDebug: true. It fails on IE trying to load firebug lite.

Somehow the iframe dojo was trying to access, or at least was affected by the main page. Maybe there's only one console shared by both the iframe and the main page. Suspicious code: In bootstrap.js dojo creates an empty console object, nulling out all the elements.

Anyway, changing the iframe page to have isDebug:false works around the problem but maybe should have a real fix.

This only fails on IE (tested on IE6, but probably same problem on IE7. not sure.)

Change History (5)

comment:1 Changed 12 years ago by James Burke

Very odd, this sounds like an IE-only issue? In that case the console object is not object (IIRC) in that browser. Maybe it has something to do with this checkin: http://trac.dojotoolkit.org/changeset/11162

There are probably not sufficient checks in the firebug.js code for the parent code.

comment:2 Changed 12 years ago by bill

Description: modified (diff)
Summary: isDebug:true iframe dojo inside isDebug:false main page dojo failsisDebug:true iframe dojo inside isDebug:false main page dojo fails (IE)

Yes, indeed odd, and I think it's only an IE problem. Updating title/summary to be more descriptive

comment:3 Changed 12 years ago by James Burke

Milestone: 1.0.1

comment:4 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [11526]) Fixes #5131. Make sure if trying to access parent frame, catch any exceptions and eat them. This is important if the iframe is on a different domain than the parent frame.

comment:5 Changed 12 years ago by James Burke

(In [11527]) Fixes #5131. Make sure if trying to access parent frame, catch any exceptions and eat them. This is important if the iframe is on a different domain than the parent frame. (Checkin for trunk)

Note: See TracTickets for help on using tickets.