Opened 12 years ago

Closed 12 years ago

#5115 closed enhancement (fixed)

[patch][cla]D.O.H. in Rhino should return an appropriate exit code when tests fail

Reported by: guest Owned by: Adam Peller
Priority: high Milestone: 1.1
Component: TestFramework Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

D.O.H., when run in Rhino, always returns an exit code of 0 (success) even if tests fail or have errors. This makes it inconvenient for use as part of automated builds. Many build systems use an exit code to determine if the command succeeded and fail the build for exit codes greater than zero.

D.O.H. under Rhino can use Rhino's quit function and pass it an integer greater than 0 if there are any test errors or failures.

Attachments (1)

exitCodeRhinoDOH.patch (513 bytes) - added by guest 12 years ago.
Patch which adds support to D.O.H. in Rhino for returning a non-zero exit code in case of errors or failures in tests.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by guest

Attachment: exitCodeRhinoDOH.patch added

Patch which adds support to D.O.H. in Rhino for returning a non-zero exit code in case of errors or failures in tests.

comment:1 Changed 12 years ago by Adam Peller

great patch, but who filed it? cla?

comment:2 Changed 12 years ago by Adam Peller

Milestone: 1.1
Owner: changed from alex to Adam Peller
Summary: D.O.H. in Rhino should return an appropriate exit code when tests fail[patch][no cla]D.O.H. in Rhino should return an appropriate exit code when tests fail

Patch filed by Jordi Albornoz Mulligan, Cambridge Semantics. Working on a CLA.

comment:3 Changed 12 years ago by Adam Peller

Summary: [patch][no cla]D.O.H. in Rhino should return an appropriate exit code when tests fail[patch][cla]D.O.H. in Rhino should return an appropriate exit code when tests fail

cla confirmed

comment:4 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [11707]) DOH from command line returns non-zero code upon exit. Thanks, Jordi. Fixes #5115.

Note: See TracTickets for help on using tickets.