Opened 12 years ago

Closed 11 years ago

Last modified 9 years ago

#5107 closed defect (fixed)

InlineEditBox: Save button not disabled after pressing Esc to revert value.

Reported by: ptbrunet Owned by: bill
Priority: high Milestone: 1.1
Component: Dijit Version: 0.9
Keywords: Cc: brunet@…
Blocked By: Blocking:

Description (last modified by Adam Peller)

Open http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_InlineEditBox.html

Tab to and open the inline with text "refrigerators", enter text, press Esc, the Save button is not disabled; it takes one more Esc to disabled it.

Fails in FF2, FF3, IE6, IE7.

Change History (6)

comment:1 Changed 11 years ago by Douglas Hays

The _onKeyPress in InlineEditBox?.js is not called during ESC key processing since the key is eaten with dojo.stopEvent.

I also noted that the Save button is initially enabled even tho nothing is changed.

comment:2 Changed 11 years ago by bill

Owner: set to bill
Status: newassigned

comment:3 Changed 11 years ago by bill

(In [11855]) Initially disable save button. Refs #5107.

comment:4 Changed 11 years ago by bill

Resolution: fixed
Status: assignedclosed

Fixed in [11857] (but I made a typo in the checkin comment, referring to a different bug number).

comment:5 Changed 9 years ago by Adam Peller

(In [21369]) doughays noticed that the parens were grouped incorrectly in r12185. Refs #5107. !strict

comment:6 Changed 9 years ago by Adam Peller

Description: modified (diff)

oops. [21369] was for #5701

Note: See TracTickets for help on using tickets.