Opened 12 years ago

Closed 12 years ago

#5065 closed defect (fixed)

[patch]widget.Chart2D fails when axis type is not default.

Reported by: guest Owned by: Eugene Lazutkin
Priority: high Milestone: 1.0.1
Component: Charting Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

To reproduce, change the test_widget2d.html by adding type="Default" to an x axis line, like this:

<div class="axis" name="x" type="Default" font="italic normal normal 8pt Tahoma"></div>

Error: dojox.charting.plot2d.axes has no properties.

Patch that fixes it:

--- dojox/charting/widget/Chart2D.js
+++ dojox/charting/widget/Chart2D.js
@@ -92,8 +92,8 @@ dojo.require("dojox.lang.functional");
                if(!name){ return null; }
                var o = {name: name, kwArgs: {}}, kw = o.kwArgs;
                if(type){
-                       if(dojox.charting.plot2d.axes[type]){
-                               type += "dojox.charting.axis2d." + type;
+                       if(dojox.charting.axis2d[type]){
+                               type = "dojox.charting.axis2d." + type;
                        }
                        var axis = eval("(" + type + ")");
                        if(axis){ kw.type = axis; }

Change History (4)

comment:1 Changed 12 years ago by Adam Peller

Keywords: patch removed
Owner: changed from Tom Trenka to Eugene Lazutkin
Summary: widget.Chart2D fails when axis type is not default.[patch]widget.Chart2D fails when axis type is not default.

Trivial enough that a CLA shouldn't be required. Eugene, can you take a look at this?

comment:2 Changed 12 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [11485]) charting: fixing typos, fixes #5065. Thx, guest.

comment:3 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: closedreopened

needs to go in 1.0 branch as well

comment:4 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

fixed in [11532]

Note: See TracTickets for help on using tickets.