Opened 12 years ago

Closed 11 years ago

#5063 closed enhancement (duplicate)

[cla][patch][needs tests[ NEW dojox.data.DBFilteredReadStore

Reported by: guest Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.2
Component: DojoX Data Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Jared Jurkiewicz)

I have made a provider for server side filtering . I started from dojo.data.ItemFileReadStore? with the method Fetch (without including dojo.data.util.simpleFetch). I named this provider dojox.data.DBFilteredReadStore and I tested with dijit.form.FilteringSelect?.

<div 
  dojoType="dojox.data.DBFilteredReadStore" 
 jsId="dataStore_TABELLA" 	  url="
Query.do?&rulename=UI_DojoGeodbProviderForFilteringSelect
&tableName=ATO
&fieldValueName=CODICE
&fieldLabelName=NOME
&fieldCodeValueFilter=${searchCodeString}
&fieldLabelValueFilter=${searchLabelString}
&pagingNumRecords=${pagingNumRecords}
&pagingStartRecord=${pagingStartRecord}"
 requestMethod="get">
</div>

Attachments (1)

DBFilteredReadStore.js (30.2 KB) - added by guest 12 years ago.
dojox.data.DBFilteredReadStore

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by guest

Attachment: DBFilteredReadStore.js added

dojox.data.DBFilteredReadStore

comment:1 Changed 12 years ago by Adam Peller

have you signed a CLA? If so, please state your name...

comment:2 Changed 12 years ago by Jared Jurkiewicz

Not to mention have you done complete unit tests against it? Is so, can you provide them? I'm wary to commit anything in that doesn't have UT that provides a sanity check that the store actually conforms.

comment:3 Changed 12 years ago by bill

This looks like a dup of dojox.data.QueryReadStore?. If there's no response in the next few weeks (as to CLA and value of this over QueryReadStore?) then let's just close the bug.

comment:4 in reply to:  1 Changed 12 years ago by guest

Replying to peller:

have you signed a CLA? If so, please state your name...

Today I send the Corporate Agreement CLA. My Dojo Account is ingpconci

comment:5 in reply to:  2 Changed 12 years ago by guest

Replying to jaredj:

Not to mention have you done complete unit tests against it? Is so, can you provide them? I'm wary to commit anything in that doesn't have UT that provides a sanity check that the store actually conforms.

Unit test, where I can find some examples? Thanks ingpconci

comment:6 in reply to:  3 Changed 12 years ago by guest

Replying to bill:

This looks like a dup of dojox.data.QueryReadStore?. If there's no response in the next few weeks (as to CLA and value of this over QueryReadStore?) then let's just close the bug.

I started from ItemFileReadStore? and my intention are to populate the FilteredSelect?. The first version of dojox.data.QueryReadStore? didn't implemented the function API required from FilteredSelect? so I decided to make new store because the implementation choosed for the QueryReadStore? are not suitable. ingpconci

comment:7 Changed 11 years ago by Jared Jurkiewicz

Examples of unit tests are in the dojox/data/tests directory. Notably things like dojox/data/tests/stores/CsvStore.js are examples of unit tests to exercise the store. In addition, dojox/data/tests/module.js should be updated to import the new Unit Tests to always check them when the tests are run for dojox.data

And, have you checked the recent implementation of QueryReadStore? to see if it works for you? It implements the identity API now, which should make it suitable for FilteringSelect?

comment:8 Changed 11 years ago by dylan

Milestone: 1.1
Summary: NEW dojox.data.DBFilteredReadStore[cla][patch][needs tests[ NEW dojox.data.DBFilteredReadStore

comment:9 Changed 11 years ago by Jared Jurkiewicz

Milestone: 1.11.2

Moved to 1.2 due to wait on contributor for reply.

comment:10 Changed 11 years ago by Jared Jurkiewicz

Description: modified (diff)

Still waiting on contributor reply. If one is not received within a month, the tracker will be closed.

comment:11 Changed 11 years ago by Jared Jurkiewicz

Resolution: duplicate
Status: newclosed

No reply from contributor. Since there has been no confirmation on if this stopre provides anything above and beyond what QueryReadStore? does, this is being closed. If the contributor wishes to reopen with a reply later, that's fine, but for now, closing.

Marking as duplicate, due to its overlap with QueryReadStore?.

Note: See TracTickets for help on using tickets.