Opened 13 years ago
Closed 13 years ago
#5063 closed enhancement (duplicate)
[cla][patch][needs tests[ NEW dojox.data.DBFilteredReadStore
Reported by: | guest | Owned by: | Jared Jurkiewicz |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | DojoX Data | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
I have made a provider for server side filtering . I started from dojo.data.ItemFileReadStore? with the method Fetch (without including dojo.data.util.simpleFetch). I named this provider dojox.data.DBFilteredReadStore and I tested with dijit.form.FilteringSelect?.
<div dojoType="dojox.data.DBFilteredReadStore" jsId="dataStore_TABELLA" url=" Query.do?&rulename=UI_DojoGeodbProviderForFilteringSelect &tableName=ATO &fieldValueName=CODICE &fieldLabelName=NOME &fieldCodeValueFilter=${searchCodeString} &fieldLabelValueFilter=${searchLabelString} &pagingNumRecords=${pagingNumRecords} &pagingStartRecord=${pagingStartRecord}" requestMethod="get"> </div>
Attachments (1)
Change History (12)
Changed 13 years ago by
Attachment: | DBFilteredReadStore.js added |
---|
comment:1 follow-up: 4 Changed 13 years ago by
have you signed a CLA? If so, please state your name...
comment:2 follow-up: 5 Changed 13 years ago by
Not to mention have you done complete unit tests against it? Is so, can you provide them? I'm wary to commit anything in that doesn't have UT that provides a sanity check that the store actually conforms.
comment:3 follow-up: 6 Changed 13 years ago by
This looks like a dup of dojox.data.QueryReadStore?. If there's no response in the next few weeks (as to CLA and value of this over QueryReadStore?) then let's just close the bug.
comment:4 Changed 13 years ago by
Replying to peller:
have you signed a CLA? If so, please state your name...
Today I send the Corporate Agreement CLA. My Dojo Account is ingpconci
comment:5 Changed 13 years ago by
Replying to jaredj:
Not to mention have you done complete unit tests against it? Is so, can you provide them? I'm wary to commit anything in that doesn't have UT that provides a sanity check that the store actually conforms.
Unit test, where I can find some examples? Thanks ingpconci
comment:6 Changed 13 years ago by
Replying to bill:
This looks like a dup of dojox.data.QueryReadStore?. If there's no response in the next few weeks (as to CLA and value of this over QueryReadStore?) then let's just close the bug.
I started from ItemFileReadStore? and my intention are to populate the FilteredSelect?. The first version of dojox.data.QueryReadStore? didn't implemented the function API required from FilteredSelect? so I decided to make new store because the implementation choosed for the QueryReadStore? are not suitable. ingpconci
comment:7 Changed 13 years ago by
Examples of unit tests are in the dojox/data/tests directory. Notably things like dojox/data/tests/stores/CsvStore.js are examples of unit tests to exercise the store. In addition, dojox/data/tests/module.js should be updated to import the new Unit Tests to always check them when the tests are run for dojox.data
And, have you checked the recent implementation of QueryReadStore? to see if it works for you? It implements the identity API now, which should make it suitable for FilteringSelect?
comment:8 Changed 13 years ago by
Milestone: | → 1.1 |
---|---|
Summary: | NEW dojox.data.DBFilteredReadStore → [cla][patch][needs tests[ NEW dojox.data.DBFilteredReadStore |
comment:9 Changed 13 years ago by
Milestone: | 1.1 → 1.2 |
---|
Moved to 1.2 due to wait on contributor for reply.
comment:10 Changed 13 years ago by
Description: | modified (diff) |
---|
Still waiting on contributor reply. If one is not received within a month, the tracker will be closed.
comment:11 Changed 13 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
No reply from contributor. Since there has been no confirmation on if this stopre provides anything above and beyond what QueryReadStore? does, this is being closed. If the contributor wishes to reopen with a reply later, that's fine, but for now, closing.
Marking as duplicate, due to its overlap with QueryReadStore?.
dojox.data.DBFilteredReadStore