Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5058 closed defect (fixed)

Bug in DnD for Tree in rel. 1.0.0

Reported by: guest Owned by: Eugene Lazutkin
Priority: high Milestone: 1.0.2
Component: Dijit Version: 1.0
Keywords: Tree DnD Cc:
Blocked By: Blocking:

Description

I'm running dijit/tests/tree/test_tree_DnD.html. Dropping from Items list to the right tree works as specified. However attempt to drag one node from this tree on any other node fails. Nor tree structure changes, neither avatar disappears although when mouse points at category node avatar displays green arrow.

When I try to drop a node from the right tree to a node on the left tree, drop is not accepted (which is OK), but avatar does not disappear.

I used IE 7.0 and Firefox 2.0.0.0.

Change History (5)

comment:1 Changed 12 years ago by guest

Here is the fix: In the function (line 141) onMouseDown into the file dijit\_treedndSource.js replace

onMouseDown: function(e){
                // summary: event processor for onmousedown
                // e: Event: mouse event
                this.mouseDown = true;
                this.inherited("onMouseDown",arguments);
        },

by

onMouseDown: function(e){
                // summary: event processor for onmousedown
                // e: Event: mouse event
                this.mouseDown = true;
                this.mouseButton = e.button;
                this.inherited("onMouseDown",arguments);
        },

It seems that this line was missing !!!!

fred

comment:2 Changed 12 years ago by bill

Component: GeneralDijit
Milestone: 1.1
Owner: changed from anonymous to Eugene Lazutkin

This is a one liner but Eugene does it look ok to you? Dustin said you are working on a similar bug (or at least something with Tree dnd) so can you check in this fix too?

comment:3 Changed 12 years ago by Eugene Lazutkin

(In [11738]) Adding missing line. Refs #5058. Thx fred!

comment:4 Changed 12 years ago by Eugene Lazutkin

Resolution: fixed
Status: newclosed

(In [11739]) Rolling in a fix from the trunk. Fixes #5058.

comment:5 Changed 12 years ago by Eugene Lazutkin

Milestone: 1.11.0.2

Both trunk and the 1.0.2 branch is updated.

Note: See TracTickets for help on using tickets.