Opened 13 years ago
Closed 13 years ago
#5055 closed defect (fixed)
add apis for consistent handling of tabindex
Reported by: | Becky Gibson | Owned by: | simonjb |
---|---|---|---|
Priority: | high | Milestone: | 1.1 |
Component: | Accessibility | Version: | 0.9 |
Keywords: | Cc: | davidb, alex, sjmiles | |
Blocked By: | Blocking: |
Description
the tabindex attribute is treated differently by the browser and between HTML and XTML. We should add apis for getting and setting tabindex attribute to avoid bugs due to these differences.
Attachments (1)
Change History (12)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Owner: | changed from Becky Gibson to simonjb |
---|
comment:3 Changed 13 years ago by
Status: | new → assigned |
---|
comment:4 Changed 13 years ago by
Cc: | davidb added |
---|
Changed 13 years ago by
comment:5 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:7 Changed 13 years ago by
Cc: | alex sjmiles added |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
We need to confirm that this belongs in _base.
comment:8 Changed 13 years ago by
comment:9 Changed 13 years ago by
comment:10 Changed 13 years ago by
In December I wrote up a post to the Dojo contributors mailing list examining the size impact of the API:
http://dojotoolkit.org/pipermail/dojo-contributors/2007-December/008530.html
I received only one response, which asked that the code be made smaller but stay in _base (http://dojotoolkit.org/pipermail/dojo-contributors/2007-December/008531.html). I have made some small size reductions and I think I will close this ticket, leaving the API in _base.
If we want to look again at moving it before 1.1 we could open a new ticket.
comment:11 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
See http://www.weba11y.com/blog/2007/11/29/fun-with-the-tabindex-attribute/ for details about tabindex
I think we should have the following apis:
setTabindex(element, value) {element.tabIndex = value;}
getTabindex(element) { element.getAttribute(tabindex); }
hasTabindex(element) { element.hasAttribute(tabindex); needs work for IE }
We also need to be consistent in templates and always specify with lowercase letter i (eye) (although tabindex is generally not in the templates any longer)