Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5041 closed defect (fixed)

[patch] patch for QueryReadStore

Reported by: liucougar Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.0.1
Component: DojoX Data Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by wolfram)

This patch adds in a new _filiterResponse function so that subclass can choose to modify the data received from server before the data is processed by QueryReadStore?

in addition, some minor cleanups

Attachments (3)

QueryReadStore.patch (3.4 KB) - added by liucougar 12 years ago.
ticket5041.diff (6.9 KB) - added by wolfram 12 years ago.
removed old assertError function
dojox.data.QueryReadStore_20071113.patch (8.1 KB) - added by Jared Jurkiewicz 12 years ago.

Download all attachments as: .zip

Change History (13)

Changed 12 years ago by liucougar

Attachment: QueryReadStore.patch added

comment:1 Changed 12 years ago by wolfram

Description: modified (diff)

I corrected the tests to work with liucougars change in getValue() which is correc, since it didnt use to be as defined by the Read API. Thanks liucougar!

Jared can you approve this? Is the _filterResponse() the way to go, or do you have any other standard way to filter incoming items for the data-strores? I am fine with this patch.

comment:2 Changed 12 years ago by wolfram

Summary: patch for QueryReadStore[patch] patch for QueryReadStore

Changed 12 years ago by wolfram

Attachment: ticket5041.diff added

removed old assertError function

comment:3 Changed 12 years ago by Jared Jurkiewicz

Having a function to add/replace (much like _fetch of the simpleFetch helper) is fine. I'll look at the suggested changes and see about committing them.

comment:4 Changed 12 years ago by Jared Jurkiewicz

Milestone: 1.0.1

comment:5 Changed 12 years ago by liucougar

I emailed Wolfram about this patch, and he is ok with it (he uploaded an updated patch)

if you don't mind, I can merge it

comment:6 Changed 12 years ago by Jared Jurkiewicz

I don't mind at all, but I'm about to do it anyway. :-) Just need to get PHP running local again.

comment:7 Changed 12 years ago by Jared Jurkiewicz

Found a bug in the QueryReadStore?.html test code. Minor fix required. Patched it. New patch coming shortly.

Changed 12 years ago by Jared Jurkiewicz

comment:8 Changed 12 years ago by Jared Jurkiewicz

Status: newassigned

Tested on: Firefox 2.0.0.9 IE 6 Safari B3 Seamonkey 1.1.2 Opera 9.2

Clean.

comment:9 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [11505]) Minor fix to QueryReadStore?. fixes #5041

comment:10 Changed 12 years ago by Jared Jurkiewicz

(In [11506]) Pulling over fix. refs #5041

Note: See TracTickets for help on using tickets.