#5041 closed defect (fixed)
[patch] patch for QueryReadStore
| Reported by: | liucougar | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | 1.0.1 |
| Component: | DojoX Data | Version: | 1.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
This patch adds in a new _filiterResponse function so that subclass can choose to modify the data received from server before the data is processed by QueryReadStore?
in addition, some minor cleanups
Attachments (3)
Change History (13)
Changed 12 years ago by
| Attachment: | QueryReadStore.patch added |
|---|
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 12 years ago by
| Summary: | patch for QueryReadStore → [patch] patch for QueryReadStore |
|---|
comment:3 Changed 12 years ago by
Having a function to add/replace (much like _fetch of the simpleFetch helper) is fine. I'll look at the suggested changes and see about committing them.
comment:4 Changed 12 years ago by
| Milestone: | → 1.0.1 |
|---|
comment:5 Changed 12 years ago by
I emailed Wolfram about this patch, and he is ok with it (he uploaded an updated patch)
if you don't mind, I can merge it
comment:6 Changed 12 years ago by
I don't mind at all, but I'm about to do it anyway. :-) Just need to get PHP running local again.
comment:7 Changed 12 years ago by
Found a bug in the QueryReadStore?.html test code. Minor fix required. Patched it. New patch coming shortly.
Changed 12 years ago by
| Attachment: | dojox.data.QueryReadStore_20071113.patch added |
|---|
comment:8 Changed 12 years ago by
| Status: | new → assigned |
|---|
Tested on: Firefox 2.0.0.9 IE 6 Safari B3 Seamonkey 1.1.2 Opera 9.2
Clean.
comment:9 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
(In [11505]) Minor fix to QueryReadStore?. fixes #5041
I corrected the tests to work with liucougars change in getValue() which is correc, since it didnt use to be as defined by the Read API. Thanks liucougar!
Jared can you approve this? Is the _filterResponse() the way to go, or do you have any other standard way to filter incoming items for the data-strores? I am fine with this patch.