Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5033 closed defect (fixed)

i18n demo: China missing from Asia

Reported by: Adam Peller Owned by: bill
Priority: high Milestone: 1.0.1
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

Reported by a user here http://dojotoolkit.org/comment/reply/4181/8299

Looks like the continent property is missing for some entries. Is this a problem with the original data or the transform script?

Change History (7)

comment:1 Changed 12 years ago by bill

It's sort of a problem w/the original data in the sense that http://en.wikipedia.org/wiki/ISO_3166-1 and http://en.wikipedia.org/wiki/List_of_countries_by_continent aren't an exact text match for China (and perhaps other countries).

Does anyone have a better data source to use to generate the data?

comment:2 Changed 12 years ago by bill

Oh I guess I found the answer to my own question: http://en.wikipedia.org/wiki/List_of_countries_by_continent_(data_file)

comment:3 Changed 12 years ago by Adam Peller

Cool, so in the spirit of keeping impact "minimal" for 1.0.1, I'd suggest we just manually fix up China on the branch and then redo the data for 1.1. Make sense?

comment:4 Changed 12 years ago by Adam Peller

(In [11479]) Associate China with Asia. Refs #5033

comment:5 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [11480]) Associate China with Asia. Fixes #5033

comment:6 Changed 12 years ago by Adam Peller

applied patch to 1.0.1 fix up China only. More comprehensive solution now moved to #5082

comment:7 Changed 12 years ago by bill

(In [13786]) Fixes #5082 and more correctly fixes #5033 by using country codes rather than country names. Unfortunately it turns out that 2-letter ISO codes aren't unique (AF is both a continent and a country), so had to construct unique key (based on type and ISO code) manually. No longer using the data inlined into generate.html but could reference it to get URLs for countries if we wanted to, so leaving there for now.

Note: See TracTickets for help on using tickets.