Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5014 closed defect (fixed)

dojo.version inconsistent between source and bin versions

Reported by: guest Owned by: James Burke
Priority: high Milestone: 1.0.1
Component: BuildSystem Version: 1.0
Keywords: version major build 101 Cc:
Blocked By: Blocking:

Description

The code for dojo.version in bootstrap.js and what is in dojo.js.uncompressed.js or elsewhere is inconsistent. The source distribution is reporting 0.9.0 while the binary is 1.0.0. Something is wrong with the build process there.

Change History (6)

comment:1 Changed 12 years ago by James Burke

Component: GeneralBuildSystem
Milestone: 1.1
Owner: changed from anonymous to James Burke
severity: majornormal

Ah, this happens because we now deliver _base with the builds (we used to not do this). Normally, bootstrap.js should not be viewed by itself as a standalone entity, and it should not be used by itself in the page. The stuff in _base after a build should be considered effectively private code. But I'll look into having the version stamped correctly.

comment:2 Changed 12 years ago by guest

I don't really care where the code is as long as it's consistent and your build process is in order. I tracked down the specific file as a service. As it is, the source distribution reports that it's version 0.9.0 and the "binary" distribution reports being 1.0.0. This messes up a bunch of my conditional code that attempts to work around the problems with various versions of Dojo. Now I can't even rely on the version number to work correctly :(

comment:3 Changed 12 years ago by Adam Peller

Keywords: 101 added

should this be addressed in 1.0.1?

comment:4 Changed 12 years ago by James Burke

Milestone: 1.11.0.1

Sure, I can give it a shot for 1.0.1. We can schedule it for 1.0.1, but we can move it to the next milestone if we run out of time.

comment:5 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [11528]) Fixes #5014. Missing import caused the stamping of bootstrap.js in the release process to fail.

comment:6 Changed 12 years ago by James Burke

(In [11529]) Fixes #5014. Missing import caused the stamping of bootstrap.js in the release process to fail. (1.0 branch checkin)

Note: See TracTickets for help on using tickets.