Opened 12 years ago

Closed 12 years ago

#5011 closed task (fixed)

unit tests for attributeMap

Reported by: bill Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

The unit tests for attributeMap have a few issues.

  1. the style check didn't work on IE; it's non-deterministic
  2. shouldn't be in _Templated.html since attributeMap is independent of _Templated

Change History (6)

comment:1 Changed 12 years ago by bill

(In [11392]) Comment out non-deterministic (is that the right word?) check. Shouldn't be accessing cssText, but rather maybe checking individual properties like border-left-color Refs #4813, #5011

comment:2 Changed 12 years ago by bill

Description: modified (diff)
Type: defect → task

comment:3 Changed 12 years ago by dylan

Milestone: → 1.2

comment:4 Changed 12 years ago by bill

(In [13604]) Remove an unnecessary level of indirection; it's not very useful (IMO) to require every HTML test file to have an associated JS stub. Perhaps composite files at a higher level (_base, form, etc.) would be useful but the current design is more trouble than it's worth.

Refs #5011 etc.

comment:5 Changed 12 years ago by bill

Description: modified (diff)

attr.html is probably a good place for these tests (there's a little bit of testing at attributeMap in there already.

comment:6 Changed 12 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [15279]) Move attributeMap tests from _Templated to to attr module, fix TODO. Fixes #5011

Note: See TracTickets for help on using tickets.