QueryReadStore and Proto*cough* incompatible [patch] [cla]

[guest]

The way the data.items is iterated through in QueryReadStore? throws an exception if Prototype 1.5 is loaded side-by-side because of the methods that Prototype adds to Array.prototype. While I can't justify use of prototype, in the real-world it happens and so compatibility should be strived for. The attached patch will iterate over the array using dojo.forEach which appropriately deals with the case.

CLA on file

dojo@…

[guest]

query read store works with prototype if you replace for(i ... array ... ) with dojo.forEach

[Adam Peller]

you should be able to pass 'this' in to dojo.forEach as an additional arg and avoid the qme decl

[guest]

quite

[Jared Jurkiewicz]

Thanks. I'll look at getting this in for 1.0.1

[dante]

fwiw you can probably just

dojo.forEach(data.items,function(e){ 
    this._items.push({i:e, r:this}); 
},this); 

[guest]

to test this thing you can try to extend Array.prototype. the dojo.forEach knows not to use array.length (which counts the funny functions that get added to the prototype) to iterate through the array members.

The exception you get when you extend Array.prototype is some sort of complaint about identifier defined but not a part of such-and-such an item (the function that extends Array.prototype, it turns out).

So the test case is to include the other javascript library (or manually extend Array.prototype) and then load a dataset with the identifier (from {identifier: id, items:[{...},...]}) specified into a combobox or unit test suite.

[Jared Jurkiewicz]

XmlStore? is also broken on this, by the by. I just fixed it too, using similar fixes. Will be generating a patch shortly.

[Jared Jurkiewicz]

Updated patch for QueryReadStore? and XmlStore? + a fix for another bug found in the QueryReadStore?.html file

[Jared Jurkiewicz]

(In [11507]) Fixes for prototype compatibility. Also fixed another bug in the simple QueryReadStore?.html test file. fixes #5004

[Jared Jurkiewicz]

(In [11508]) Carrying fix forward. refs #5004