Opened 12 years ago

Closed 12 years ago

#4971 closed defect (fixed)

toolbar with dropdowns (editor font choices) broken on IE

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.1
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

because they're not popups, the focus is not managed correctly. Fix for 1.0 or remove support for this feature until this is fixed.

Change History (15)

comment:1 Changed 12 years ago by bill

There is an infrastructure for this, but it's complicated because you have to restore focus and selection *before* executing the font-change. Look at Menu.js for a related example. I think it would work something like:

  • when toolbar gets the synthetic _onFocus() event, call {{prevFocus = dijit.getFocus(this); }}} to save the previous focus and selection from the <div> (there's a bit of magic in that it remembers that the <div> was focused even though focus has already moved to something else; it remembers the last focused item)
  • somehow the toolbar's children widgets need to have access to that prevFocus variable so they can restore focus+selection before executing themselves. Or maybe you can setup before-advice on the children to restore focus and selection before they execute.

comment:2 Changed 12 years ago by Adam Peller

(In [11325]) Take font dropdowns out of the test, since they don't yet work in IE. Refs #4971.

comment:3 Changed 12 years ago by Adam Peller

Milestone: 1.01.1
Owner: changed from Adam Peller to liucougar

Cougar, can you take a look at this? I tried using the focus code as well as calling the editor's bookmark code directly to save/restore focus, but nothing worked. It appears that Editor may already be trying to do this on behalf of the plugin. So why is there a focus problem only on IE? It almost looks like a cross-domain issue trying to access the iframe?

comment:4 Changed 12 years ago by Adam Peller

Priority: normalhigh

comment:5 Changed 12 years ago by Adam Peller

blocking the use of the feature in #4171

comment:6 Changed 12 years ago by Adam Peller

(In [11884]) FontChoice? editor plugin should have been marked 'experimental'. Refs #4971, Refs #4171

comment:7 Changed 12 years ago by Adam Peller

(In [11885]) FontChoice? editor plugin should have been marked 'experimental'. Refs #4971, Refs #4171

comment:8 Changed 12 years ago by Adam Peller

Cc: alex added

this is a must have for 1.1

comment:9 Changed 12 years ago by Adam Peller

Cc: alex removed
Owner: changed from liucougar to alex

comment:10 Changed 12 years ago by alex

Status: newassigned

comment:11 Changed 12 years ago by Adam Peller

(In [12768]) Use bookmarks (working now) to control selection and focus. Refs #4971

comment:12 Changed 12 years ago by Adam Peller

Owner: changed from alex to Adam Peller
Status: assignednew

comment:13 Changed 12 years ago by Adam Peller

(In [12770]) Remove 'experimental.' Refs #2439, #4171, #4971

comment:14 Changed 12 years ago by Adam Peller

(In [12772]) Avoid setting font properties on update. onChange seems to fire on setValue as well as user interaction. Refs #4171, #4971

comment:15 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.