Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#4939 closed defect (worksforme)

initial empty filteringselect shows warning icon

Reported by: Adam Peller Owned by: haysmark
Priority: high Milestone: 1.0
Component: Dijit - Form Version: 0.9
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

In the same spirit as #4427, I think FilteringSelect should not show an error state when displayed with initial empty content. See test_FilteringSelect #2

Attachments (1)

4939.patch (410 bytes) - added by haysmark 12 years ago.
Added _hasBeenBlurred state variable to FilteringSelect? validation code. Fixes #4939.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 12 years ago by bill

Note: this ticket is about a FilteringSelect? with an invalid (ie, null) value, much like DateTextBox? with no date set. It isn't about when "" is one of the choices in the drop down list, and that's the initially selected choice (which presumably works fine).

comment:2 Changed 12 years ago by Douglas Hays

Cc: Douglas Hays added; haysmark removed
Owner: changed from Douglas Hays to haysmark

comment:3 Changed 12 years ago by Adam Peller

I'm actually having trouble with the "" case in IE also (see test_Editor.html)

Changed 12 years ago by haysmark

Attachment: 4939.patch added

Added _hasBeenBlurred state variable to FilteringSelect? validation code. Fixes #4939.

comment:4 Changed 12 years ago by haysmark

This patch throws it in.

comment:5 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [11246]) Fixes #4939. Removed check for required=true in the code that supresses the initial error icon.

comment:6 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: closedreopened

still broken on Webkit

comment:7 Changed 12 years ago by Douglas Hays

Resolution: worksforme
Status: reopenedclosed

seems to work using safari 3.0.3 in winXP

comment:8 Changed 12 years ago by haysmark

Tested on WebKit?-r26759 and it works.

comment:9 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.