Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4931 closed defect (fixed)

query match on simple, non-string types

Reported by: Adam Peller Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.0
Component: Data Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

doing a query like name="*" should match on Numbers and booleans as well as strings. Perhaps just do a toString() before the regexp match

Attachments (1)

dojo.data.ItemFileStoreTests_20071031.patch (4.5 KB) - added by Jared Jurkiewicz 12 years ago.
Couple UT cases for this.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by Adam Peller

(In [11187]) Fix bugs in _containsValue - wasn't searching the whole list. Use dojo.some. use toString() for regexp match on primitives. Refs #4931. Still needs UT.

comment:2 Changed 12 years ago by Adam Peller

(In [11188]) oops. remove commented out code. Refs #4931

comment:3 Changed 12 years ago by Adam Peller

Milestone: 1.01.1
Owner: changed from Adam Peller to Jared Jurkiewicz

would like to be helpful and write a test for this, but I get lost in the dojo.data test file :-(

comment:4 Changed 12 years ago by Jared Jurkiewicz

Yes, this should have UT for it. I'll look at adding that soon.

Changed 12 years ago by Jared Jurkiewicz

Couple UT cases for this.

comment:5 Changed 12 years ago by Jared Jurkiewicz

Tests executed on:

FireFox? 2.0.0.8 IE 6 Safari B3 Seamonkey 1.1.2 Opera 9.2 IE 7 Firefox 1.5.0.12

Console with Rhino.

All pass.

comment:6 Changed 12 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [11281]) Couple UT. fixes #4931

comment:7 Changed 12 years ago by bill

Milestone: 1.11.0
Note: See TracTickets for help on using tickets.