#4918 closed defect (fixed)
dijit.form.Textarea tries to access window.frameElement properties even when it is null
Reported by: | guest | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Dijit - Form | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
There is a script in dijit.form.Textarea which attempts to grab the window.frameElement.postCreate function and execute it. It however does not work when window.frameElement does not have any properties or is null.
I am not sure if this is a Textarea bug specifically that causes frameElement to be null, but it only happens after I destroy a previous Textarea, and possibly after I destroy a dijit.Tree (not completely sure whether it is relevant though. The first creation of a Textarea is fine, it just falls over when I try to create one later in the applications life.
I made a simple patch to do a sanity check on window.frameElement so that it does not fail, as there is already a lower level check so it seems to be an optional action.
Attaching a patch against dijit trunk svn as at revision 11169.
Attachments (2)
Change History (7)
Changed 13 years ago by
Attachment: | fixWindowFrameElement.diff added |
---|
comment:1 Changed 13 years ago by
Owner: | set to Douglas Hays |
---|
Would feel a lot better with a testcase for this (attached using the "attach file" button)
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 13 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
On FF2 mac (and probably windows) this causes a syntax error on load of themeTester.html or test_textarea.html.
comment:4 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
comment:5 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
patch for Textarea.js