Opened 12 years ago

Closed 12 years ago

#4917 closed enhancement (fixed)

dojox.fx.NodeList-fx proposal

Reported by: dante Owned by: dante
Priority: high Milestone: 1.1
Component: Dojox Version: 0.9
Keywords: Cc: Tom Trenka, alex
Blocked By: Blocking:

Description

the new extension setup for NodeList? is great. dojo.require("dojo.NodeList?-fx"); the root dojo.NodeList? has cool animation functions. dojo.query('.foo').fadeOut().play();

dojox.fx is a project that has extension animations.

i have created a module that adds in mappings for the dojox.fx animations to use NodeList?-fx's _anim code.

I am not technically allowed to extend dojo.NodeList? from dojox. But do not want to make aliases and extend dojo.query to dojox.query (and may not even be "allowed" to from withing the /dojox/fx/ project) so use dojox.NodeList?, etc etc ...

I am proposing a clearly marked experimental module that warns the user of cross-namespace clobbering in a dojo.experimental() as a means to provide the user a simple way to experiment.

dojo.require("dojox.fx.NodeList?-fx") would throw the warning, and dojo.extend(dojo.NodeList?,...); the biggest concern would be the doc parser mixing in the documentation for the .hightlight() .slideBy() and .sizeTo() methods into the core NodeList? class.

Attachments (1)

NodeList-fx.patch (1.7 KB) - added by dante 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by dante

Attachment: NodeList-fx.patch added

comment:1 Changed 12 years ago by Adam Peller

Pete - IIUC this sounds like a 1.1 or 2.0 item (though neither is well-defined at this point) not an emergency fix. Can you reschedule?

comment:2 Changed 12 years ago by dante

Resolution: wontfix
Status: newclosed

comment:3 Changed 12 years ago by Adam Peller

Milestone: 1.0.11.0

comment:4 Changed 12 years ago by dante

Milestone: 1.01.1
Resolution: wontfix
Status: closedreopened

comment:5 Changed 12 years ago by dante

Resolution: fixed
Status: reopenedclosed

(In [11574]) fixes #4917 - this change crosses namespaces, and extends dojo.NodeList? with the dojox.fx animations .slideBy, .sizeTo, .highlight, and .fadeTo (the last just being a wrapper to dojo._fade directly). adds a pretty neat interative dojo.query() / NodeList?-fx test page, and updates all the other fx test files to demo a query animation. also some cleanups to the base animations.

Note: See TracTickets for help on using tickets.