Opened 12 years ago

Closed 10 years ago

#4910 closed enhancement (fixed)

disable submit on editor createlink dialog when !valid

Reported by: Adam Peller Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.4
Component: Editor Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

the validation textbox checks for non-conformant/ non-empty url data, but the set button is not disabled.

Change History (10)

comment:1 Changed 12 years ago by Adam Peller

Milestone: 1.0.11.1

comment:2 Changed 11 years ago by Adam Peller

Owner: changed from liucougar to Adam Peller

comment:3 Changed 11 years ago by Adam Peller

Milestone: 1.11.2
Summary: editor createlink dialog allows invalid urldisable submit on editor createlink dialog when !valid
Type: defectenhancement

we could override onSubmit, I think? Or perhaps _FormMixin should provide this functionality?

comment:4 Changed 11 years ago by bill

See #4692, which is a more general version of this bug.

comment:5 Changed 11 years ago by Adam Peller

Milestone: 1.2tbd

comment:6 Changed 11 years ago by bill

Milestone: tbd1.3
Owner: changed from Adam Peller to nonken

Nikolai is working on a big refactor of the create link/image dialogs so assigning to him.

comment:7 Changed 11 years ago by nonken

Status: newassigned

comment:8 Changed 11 years ago by bill

Milestone: 1.31.4

comment:9 Changed 10 years ago by bill

Owner: changed from nonken to Jared Jurkiewicz
Status: assignednew

Jared you might want to grab this one since you were working on link dialog's recently, but feel free to punt to 1.5.

comment:10 Changed 10 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [20364]) Committing in minor enhancement to disable set on invalid input. fixes #4910

Note: See TracTickets for help on using tickets.