Opened 12 years ago

Closed 11 years ago

Last modified 10 years ago

#4908 closed defect (fixed)

[patch] dojo.connect() to "onkeypress" memory leak (IE)

Reported by: bill Owned by: sjmiles
Priority: high Milestone: 1.1
Component: Events Version: 0.9
Keywords: Cc: davidb
Blocked By: Blocking:

Description

Event code creates a stealth handler for "onkeydown" but never deletes it. Leaks about 1M per 1000 connect()/disconnect() pairs. Patch attached.

Attachments (3)

leak.html (802 bytes) - added by bill 12 years ago.
test case showing leak
functionality.html (519 bytes) - added by bill 12 years ago.
test case to make sure onkeypress is still working
onkeypress.diff (1.3 KB) - added by bill 12 years ago.
patch to reference count stealth onkeydown handler and delete as appropriate

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by bill

Attachment: leak.html added

test case showing leak

Changed 12 years ago by bill

Attachment: functionality.html added

test case to make sure onkeypress is still working

Changed 12 years ago by bill

Attachment: onkeypress.diff added

patch to reference count stealth onkeydown handler and delete as appropriate

comment:1 Changed 12 years ago by davidb

Cc: davidb added

comment:2 Changed 11 years ago by sjmiles

Resolution: fixed
Status: newclosed

(In [12598]) Fixes #4908 (thanks Bill). !strict because the pre-commit hook is confused about return types.

Note: See TracTickets for help on using tickets.