Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#4901 closed defect (fixed)

API consistancy / optimizations in dijit

Reported by: dante Owned by: dante
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

this.inherited() should be used over className.superclass.apply/call

where possible, we should be using this.connect() over dojo.connect all within dojo.declare()

in theory, shrinksafe will be nicer to use wrt to optimization, and this techmo will also let dijit's internal garbage collection / connection tracking stability.

Change History (14)

comment:1 Changed 12 years ago by dante

(In [11133]) refs #4901 - doc and superclass cleanups to stackcontainer.

comment:2 Changed 12 years ago by dante

(In [11134]) refs #4901 - moves lots of tab templateString to new file as well as cleanups on superclass calls.

comment:3 Changed 12 years ago by dante

(In [11135]) refs #4901 -

it's no longer EXAMPLES: it's "example:" says pottedmeat ... (sorry for the confusion alex) another mild cleanup.

comment:4 Changed 12 years ago by dante

(In [11136]) refs #4901 - other cleanups and doc cleanups etc. still going.

comment:5 Changed 12 years ago by dante

(In [11137]) refs #4901 - really, doing it one at a time so an individual checking can be reverted in the event i miss something in testing each portion.

comment:6 Changed 12 years ago by dante

(In [11139]) refs #4901 - cleanups.

comment:7 Changed 12 years ago by dante

Resolution: fixed
Status: newclosed

i think i got them all regarding this.

comment:8 Changed 12 years ago by bill

Milestone: 2.01.0

comment:9 Changed 12 years ago by dante

(In [11498]) refs #4820 and refs #4901 - doc additions and one small superlclass.apply change

comment:10 Changed 11 years ago by dante

(In [11660]) refs #4611 - remove usage:, use example: (though not being picked up atm) and refs #4901 - one this.inherited() change

comment:11 Changed 11 years ago by dante

(In [11743]) doc cleanups to dijit.form.Button - refs #4901 ?

comment:12 Changed 11 years ago by dante

(In [12341]) refs #4901 - this.inherited() stuff, and small style changes.

comment:13 Changed 11 years ago by dante

(In [12342]) refs #4901 - cleanups.

comment:14 Changed 11 years ago by dante

(In [12344]) refs #4901 - cleanups

Note: See TracTickets for help on using tickets.