Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#4890 closed enhancement (fixed)

common base for TimeTextBox and DateTextBox

Reported by: Adam Peller Owned by: Douglas Hays
Priority: high Milestone: 1.1
Component: Dijit - Form Version: 0.9
Keywords: Cc: bill
Blocked By: Blocking:

Description

Right now, DateTextBox? picks up all the time code as well as the _TimePicker popup, which are never used by DateTextBox?. Not crazy about deep OO hierarchies, but it may be worth doing here.

Change History (12)

comment:1 Changed 12 years ago by haysmark

Version: 0.91.0

comment:2 Changed 12 years ago by haysmark

So the exact problem is the fact that TimePicker? gets dojo.required, and that constraints gets set twice, right?

I originally committed TimeTextBox? as a widget that did dates and times, and DateTextBox? just added the date constraint, so the change to make TimeTextBox? only handle times threw that off.

So what I would plan to do is move the code into a DateTimeTextbox? with popupClass=null, per #4889. Then TimeTextBox? and DateTextBox? would both look like how DateTextBox? is now, with the popup require and constraints statement. Ok?

comment:3 Changed 12 years ago by haysmark

Milestone: 1.0
Version: 1.00.9

comment:4 Changed 12 years ago by Adam Peller

Yeah, something like that (I'm not sure popupClass would even have to be defined in the base class) but I'm not sure we should be pushing so many tickets into 1.0 at this late date. If we can do this in 1.1 without changing any existing public APIs, I'd suggest we wait. Everything works now, it just results in a bit of code drag.

comment:5 Changed 12 years ago by Adam Peller

Milestone: 1.01.1

comment:6 Changed 12 years ago by Douglas Hays

Owner: changed from haysmark to Douglas Hays

comment:7 Changed 12 years ago by Douglas Hays

(In [11914]) References #4890. Rename TimeTextBox?.js to _DateTimeTextBox.js to carry forward change history. !strict

comment:8 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [11915]) Fixes #4890. DateTextbox? and TimeTextBox? call common base class. !strict

comment:9 Changed 12 years ago by Adam Peller

(In [11951]) Include TimeTextBox?. refs #4890, fixes #5505.

comment:10 Changed 12 years ago by Adam Peller

(In [12233]) fix up test constraints. Add pattern override test case. Refs #4890. q2 invalidMessage implied en-us date pattern. Range message was wrong (q3)

comment:11 Changed 12 years ago by Adam Peller

(In [12234]) remove extra quote. Refs #4890

comment:12 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.