Opened 14 years ago

Closed 13 years ago

Last modified 12 years ago

#486 closed enhancement (wontfix)

[patch][need cla] Add numeric formatting, like the way it does date formatting

Reported by: me@… Owned by: Adam Peller
Priority: high Milestone:
Component: General Version: 0.3
Keywords: Numeric Formating Cc:
Blocked By: Blocking:

Description

I wanted you to added more numeric formation like the way it does date formatting. For example currency formating.

Attachments (1)

LocalizedNumbers.js (3.5 KB) - added by leonardo@… 14 years ago.
Localized parsing and formatting number functions

Download all attachments as: .zip

Change History (9)

comment:1 Changed 14 years ago by leonardo@…

Type: defectenhancement

I implemented basic numeric formatting, including options for signs, thousand separators, decimal separators and decimal rounding. A solution more alike to Decimal Format http://java.sun.com/j2se/1.5.0/docs/api/java/text/DecimalFormat.html would be better though.

Changed 14 years ago by leonardo@…

Attachment: LocalizedNumbers.js added

Localized parsing and formatting number functions

comment:2 Changed 14 years ago by anonymous

Owner: changed from ttrenka@… to Tom Trenka

comment:3 Changed 14 years ago by anonymous

Milestone: 0.3release0.3.1

comment:4 Changed 13 years ago by alex

is there a CLA on file for this patch?

Tom? have you reviewed it yet? It's getting quite long in the tooth and it's unsightly for us to have patches sitting around this long.

comment:5 Changed 13 years ago by Tom Trenka

Milestone: 0.3.10.4

I don't know if there's a CLA for this patch...to be honest I didn't even know there was a patch submitted.

My feeling on this is to wait and do this with the i8ln efforts, the beginnings of which has landed in the core. Looking over the submitted patch, I also think there's probably a better of way of doing it (it's not bad but it is a little verbose, I think there's probably a better way of doing it using regular expressions).

Gonna push this out a bit and see where i8ln is.

comment:6 Changed 13 years ago by dylan

Owner: changed from Tom Trenka to Adam Peller
Summary: Add numeric formatting, like the way it does date formatting[patch][need cla] Add numeric formatting, like the way it does date formatting

comment:7 Changed 13 years ago by Adam Peller

Resolution: wontfix
Status: newclosed

We've got something in the works for numbers in dojo.i18n.number, still marked experimental. I think it supercedes the patch here.

comment:8 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.