Opened 12 years ago

Closed 11 years ago

#4848 closed defect (fixed)

arrow key navigation in grid scrolls too much

Reported by: Adam Peller Owned by: benschell
Priority: high Milestone: 1.1
Component: DojoX Grid Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

(tested on FF2)

hit the down arrow in the grid. It will take you down one row but also scroll the grid -- perhaps the event is bubbling when it shouldn't? Now, press and hold the arrow. The cell selection will change by one, but the grid will continue to scroll until the selected cell is out of view.

Perhaps the scrolling should only occur when the selection takes you beyond the visible range of cells? page up/page down work well.

Attachments (2)

4848.patch (1.6 KB) - added by benschell 11 years ago.
Stops scroll events, ensures scrolling by keyboard works properly.
4848.2.patch (542 bytes) - added by benschell 11 years ago.
New fix for left/right scrolling issue.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by Adam Peller

Owner: changed from sjmiles to sorvell

comment:2 Changed 12 years ago by Becky Gibson

Milestone: 1.0

comment:3 Changed 11 years ago by benschell

Owner: changed from sorvell to benschell

I'm taking a stab at a whole bunch of Grid bugs. Re-assigning.

Changed 11 years ago by benschell

Attachment: 4848.patch added

Stops scroll events, ensures scrolling by keyboard works properly.

comment:4 Changed 11 years ago by benschell

Status: newassigned

comment:5 Changed 11 years ago by Jared Jurkiewicz

Resolution: fixed
Status: assignedclosed

(In [12524]) Fix for pageUp, pageDown, and arrow key focus behavior from Ben Schell. fixes #4848

comment:6 Changed 11 years ago by benschell

Resolution: fixed
Status: closedreopened

Re-opening: the right/left keys still scroll the scrollbar AND the focus at the same time. This should be fixed so that the scrollbar only moves iff we're at the edge of the box (and therefore moving the focus to a box currently out of view).

Changed 11 years ago by benschell

Attachment: 4848.2.patch added

New fix for left/right scrolling issue.

comment:7 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

(In [13031]) Add BiDi? keyboard logic, stop key events from bubbling. Fixes #4848, Fixes #6046

Note: See TracTickets for help on using tickets.