Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4839 closed defect (fixed)

kill stray globals

Reported by: alex Owned by: alex
Priority: high Milestone: 1.0
Component: Core Version: 0.9
Keywords: Cc: dylan, bill
Blocked By: Blocking:

Description

I'm seeing stray globals like "gearsObj", "_shouldRequire", "dojoUrl", "param", "tp", "x", and "undefined_undefined"...and that's just on the NodeList? test page.

Change History (14)

comment:1 Changed 12 years ago by alex

(In [11067]) clobber the "gearsObj" stray global. Refs #4839

comment:2 Changed 12 years ago by alex

(In [11068]) put global code in a scope protection closure. Refs #4839

comment:3 Changed 12 years ago by alex

(In [11069]) clobbery stray global "param" name. Refs #4839

comment:4 Changed 12 years ago by alex

(In [11070]) removing a stray global in the test. Refs #4839

comment:5 Changed 12 years ago by alex

the undefined_undefined seems to be coming from delcare(), but I'm not sure where

comment:6 Changed 12 years ago by alex

(In [11220]) keep "pStart" out of the global namespace. Refs #4839

comment:7 Changed 12 years ago by alex

(In [11221]) scope things down to make detection of bogus globals easier. Refs #4839

comment:8 Changed 12 years ago by alex

(In [11222]) keep declare() from leaking stray globals when there's no superclass. Updating docs for parser conformance. Refs #4839

comment:9 Changed 12 years ago by alex

(In [11223]) killing stray global. Refs #4839

comment:10 Changed 12 years ago by alex

Resolution: → fixed
Status: new → closed

seems to be cleared up, at least in themeTester.html. Marking fixed.

comment:11 Changed 12 years ago by alex

(In [11330]) preventing stray global. Fixes #4992. Refs #4839

comment:12 Changed 12 years ago by sjmiles

(In [11340]) No reason to put intermediate delegates into any namespace. Prefer simply removing this code. Refs #4839.

comment:13 Changed 12 years ago by alex

(In [11348]) good spot by Neil. Clobbering stray global. Refs #4839

comment:14 Changed 12 years ago by Adam Peller

(In [12852]) Log stray globals to console. Refs #4839

Note: See TracTickets for help on using tickets.