Opened 12 years ago

Closed 11 years ago

#4836 closed defect (invalid)

document.documentElement.clientWidth in ie quirks mode

Reported by: guest Owned by: sjmiles
Priority: high Milestone: 1.2
Component: HTML Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

when dojo.isIE and document.compatMode == "BackCompat?" both true, the document.documentElement.clientWidth is always be zero, so dojo._fixIeBiDiScrollLeft(dojo/_base/html.js line 824 revision 11061) will get a wrong value in this situation.

Attachments (1)

html.js.patch (631 bytes) - added by guest 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by guest

Attachment: html.js.patch added

comment:1 Changed 12 years ago by dylan

Milestone: 1.2
Summary: document.documentElement.clientWidth in ie quirks mode[patch][needs cla] document.documentElement.clientWidth in ie quirks mode

Who is this patch from? Is there a CLA on file?

comment:2 Changed 11 years ago by Adam Peller

trivial enough that a CLA is not needed. Can we apply this patch?

comment:3 Changed 11 years ago by sjmiles

The current code has some logic based on BackCompat? that is different than this patch.

var de = dd.compatMode == "BackCompat" ? dd.body : dd.documentElement;

It looks likely that it addresses this problem, but no test file was provided.

Unless somebody can provide more info, I'm going to mark this as 'invalid'.

comment:4 in reply to:  3 Changed 11 years ago by sjmiles

Replying to sjmiles:

It looks likely that it addresses this problem, but no test file was provided.

I mean to say there is no test attached to this ticket that I can use to verify this problem.

comment:5 Changed 11 years ago by bill

Resolution: invalid
Status: newclosed
Summary: [patch][needs cla] document.documentElement.clientWidth in ie quirks modedocument.documentElement.clientWidth in ie quirks mode

Marking invalid since no test case. This is probably fixed anyway (see above).

Note: See TracTickets for help on using tickets.