Opened 12 years ago

Closed 12 years ago

#4827 closed defect (fixed)

dojox.widget.Loader doesnot publish messages started/ended

Reported by: guest Owned by: dante
Priority: high Milestone: 1.0
Component: Dojox Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

instead of call dojo.publish("Loader", { message: 'ended' }); have to call dojo.publish("Loader", [{ message: 'ended' }]); patch fixes this 

Index: dojox/widget/Loader.js
===================================================================
--- dojox/widget/Loader.js	(revision 11043)
+++ dojox/widget/Loader.js	(working copy)
@@ -76,7 +76,7 @@
 
 	_show: function(){
 		// summary: publish and show progress indicator
-		dojo.publish("Loader",{ message: 'started' });
+		dojo.publish("Loader",[{ message: 'started' }]);
 		if(this.hasVisuals){ 
 			if(this.attachToPointer){
 				this._pointerConnect = dojo.connect(document,"onmousemove",this,"_putLoader");
@@ -87,7 +87,7 @@
 
 	_hide: function(){
 		// summary: publish "xhr ended" and hide progress indicator
-		dojo.publish("Loader", { message: 'ended' });
+		dojo.publish("Loader", [{ message: 'ended' }]);
 		if(this.hasVisuals){ 
 			if(this.attachPointer){
 				dojo.disconnect(this._pointerConnect);

Change History (2)

comment:1 Changed 12 years ago by dante

Milestone: → 1.0
Owner: changed from Tom Trenka to dante
Status: new → assigned

comment:2 Changed 12 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [11047]) fixes #4827 - no-brainer messup in dojox.widget.Loader publish calls.

Note: See TracTickets for help on using tickets.