Opened 15 years ago

Closed 15 years ago

#4812 closed defect (fixed)

_TimePicker and _Calendar should be peers

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.0
Component: Dijit Version: 0.9
Keywords: Cc: bill
Blocked By: Blocking:


We agonized over this and ended up putting _Calendar in dijit since it's not a form. Even though they're private for a11y reasons, in theory they can be used standalone w/o a form. Whatever we do, I think they ought to live in the same place.

Let's confirm with Bill et al

Change History (4)

comment:1 Changed 15 years ago by haysmark

I put TimePicker? in form just because only TimeTextBox?, a form widget, uses it. I would think Calendar would follow the same logic.

I tried putting a TimePicker? in a standalone page and it kind of . . . exploded. I think it is heavily dependent on the popup code.

Because they are private do we skip deprecation of the old spot if we move one?

comment:2 Changed 15 years ago by Adam Peller

yes, the private mark gives us some flexibility. it's nice, IMO, if the subwidget doesn't rely on popups or the parent (like _Calendar), but I guess it's not a requirement.

comment:3 Changed 15 years ago by bill

Owner: changed from haysmark to Adam Peller

OK, let's put them both in base.

comment:4 Changed 15 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [11130]) Move dijit.form._TimePicker to dijit. Fixes #4812

Note: See TracTickets for help on using tickets.