Opened 12 years ago
Closed 12 years ago
#4812 closed defect (fixed)
_TimePicker and _Calendar should be peers
| Reported by: | Adam Peller | Owned by: | Adam Peller |
|---|---|---|---|
| Priority: | high | Milestone: | 1.0 |
| Component: | Dijit | Version: | 0.9 |
| Keywords: | Cc: | bill | |
| Blocked By: | Blocking: |
Description
We agonized over this and ended up putting _Calendar in dijit since it's not a form. Even though they're private for a11y reasons, in theory they can be used standalone w/o a form. Whatever we do, I think they ought to live in the same place.
Let's confirm with Bill et al
Change History (4)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
yes, the private mark gives us some flexibility. it's nice, IMO, if the subwidget doesn't rely on popups or the parent (like _Calendar), but I guess it's not a requirement.
comment:3 Changed 12 years ago by
| Owner: | changed from haysmark to Adam Peller |
|---|
OK, let's put them both in base.
comment:4 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
I put TimePicker? in form just because only TimeTextBox?, a form widget, uses it. I would think Calendar would follow the same logic.
I tried putting a TimePicker? in a standalone page and it kind of . . . exploded. I think it is heavily dependent on the popup code.
Because they are private do we skip deprecation of the old spot if we move one?