Opened 12 years ago
Closed 12 years ago
#4724 closed defect (fixed)
dojox.data.FlickrRestStore manipulates paging info on source Request object
| Reported by: | sos | Owned by: | Jared Jurkiewicz |
|---|---|---|---|
| Priority: | high | Milestone: | 1.0 |
| Component: | DojoX Data | Version: | 0.9 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
When a request object is passed to the FlickrRestStore?, it may or may not modify the start and count parameters of that object, This should not happen, as the client may be depending on those parameters for their paging.
Also,this can lead to paging errors, with data not being retrieved correctly
Attachments (2)
Change History (9)
comment:1 Changed 12 years ago by
| Component: | General → DojoX Data |
|---|---|
| Milestone: | → 1.0 |
| Owner: | changed from anonymous to Jared Jurkiewicz |
| severity: | normal → major |
Changed 12 years ago by
| Attachment: | dojox.data.FlickrRestStore_paging_error.patch added |
|---|
comment:3 Changed 12 years ago by
| Status: | new → assigned |
|---|
Accepting for now. Will review/test/commit if it seems clean.
comment:4 Changed 12 years ago by
Ran UT against this patch on browsers:
IE 6 IE 7 Firefox 1.5.0.12 Firefox 2.0.0.7 Safari B3 Seamonkey 1.1.2 Opera 9.2
Changed 12 years ago by
| Attachment: | 20071015-FlickrRestStore.patch added |
|---|
Regenned patch based off current tree and SVN diff.
comment:5 Changed 12 years ago by
I removed the dojo._hasResource[] line from the top of the file. Shouldn't be accessing private arrays of the dojo object.
comment:6 Changed 12 years ago by
Damn, sorry about that - I must've used the built version of the file. The build system inserts that line
Shane
comment:7 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Patch to fix paging error