stack container has no wai roles or states specified

[Becky Gibson]

Since stack container behaves like a tab container it probably makes sense to use the tabcontainer, tablist, and tab roles.

[Dustin Machi]

Hmm, I would think that it is the controller that needs wai roles and states not the stack container ourself. Unlike tab container, stack container doesn't have any buttons or navigation by default and is typically used as the base class for other types of widgets that display one item out of the stack at a time or it is used to place this type of content in an arbitrary place and a customer controller is used to change its currently viewable item.

[davidb]

Note oddly StackController? has wairole="tablist" in the template as well as dijit.setWaiRole(this.domNode, "tablist") in postCreate. Why is this?

Patch coming up for tab and tabpanel roles.

[davidb]

possible fix

[davidb]

Becky we should probably chat about the patch; by adding some wai role setting in the Stack* 'classes' I was able to remove setting it in the 'subclasses'.

I'm not sure though... should I leave the duplication for code visibility (someone looking at the TabContainer template for example)? Also is leaving the duplication in safer against potential dijit design flux?

Note also, I haven't completed testing of the patch yet.

[davidb]

(In [11100]) Fixes #4700, added tab and tabpanel aria roles to stack container and removed duplication in 'subclasses' accordion and tabcontainer.

[davidb]

(In [11106]) Override stack container wai role in accordion due to different node hierarchy, and revert wai roles in template. Refs #4700