#4700 closed defect (fixed)
stack container has no wai roles or states specified
Reported by: | Becky Gibson | Owned by: | davidb |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Accessibility | Version: | 0.9 |
Keywords: | Cc: | Adam Peller, davidb | |
Blocked By: | Blocking: |
Description
Since stack container behaves like a tab container it probably makes sense to use the tabcontainer, tablist, and tab roles.
Attachments (1)
Change History (7)
comment:1 Changed 13 years ago by
Owner: | changed from Becky Gibson to davidb |
---|
comment:2 Changed 13 years ago by
comment:3 Changed 13 years ago by
Status: | new → assigned |
---|
Note oddly StackController? has wairole="tablist" in the template as well as dijit.setWaiRole(this.domNode, "tablist") in postCreate. Why is this?
Patch coming up for tab and tabpanel roles.
comment:4 Changed 13 years ago by
Becky we should probably chat about the patch; by adding some wai role setting in the Stack* 'classes' I was able to remove setting it in the 'subclasses'.
I'm not sure though... should I leave the duplication for code visibility (someone looking at the TabContainer template for example)? Also is leaving the duplication in safer against potential dijit design flux?
Note also, I haven't completed testing of the patch yet.
comment:5 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Hmm, I would think that it is the controller that needs wai roles and states not the stack container ourself. Unlike tab container, stack container doesn't have any buttons or navigation by default and is typically used as the base class for other types of widgets that display one item out of the stack at a time or it is used to place this type of content in an arbitrary place and a customer controller is used to change its currently viewable item.