Opened 13 years ago

Closed 12 years ago

#470 closed defect (fixed)

Toolbar: Icon toolbar button can cause Firefox Throbber to start

Reported by: gavin-dojo@… Owned by: bill
Priority: high Milestone: 0.9
Component: Dijit Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

If I load the HTML below into Firefox 1.501 in either OSX or Windows XP, then click on the 'g1' button in the toolbar, the throbber spins for no reason that appears obvious.

Doesn't happen if the button isn't in a button group. Doesn't happen if there are no icon buttons in the group. Doesn't happen if I create the HTML layout procedurally. 

<?xml version="1.0"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:svg="http://www.w3.org/2000/svg" xmlns:xhtml="http://www.w3.org/1999/xhtml" xmlns:xlink="http://www.w3.org/1999/xlink">
<head>
<style>
html, body{	
  width: 100%;	/* make the body expand to fill the visible window */
  height: 100%;
  overflow: hidden;	/* erase window level scrollbars */
  padding: 0 0 0 0;
  margin: 0 0 0 0;
}
.toolbarCanvas {
}

</style>
<script type="text/javascript">
var djConfig = {
    isDebug: false,
    debugAtAllCosts: false,
    ieClobberMinimal : true
  };
</script>

<script type="text/javascript" src="javascripts/dojo/dojo.js"></script>

<script type="text/javascript">
dojo.require("dojo.widget.ContentPane");
dojo.require("dojo.widget.LayoutPane");
dojo.require("dojo.widget.Toolbar");
dojo.require("dojo.widget.ColorPalette");
</script>

</head>
<body id="root">

<div dojoType="LayoutPane" layoutChildPriority="top-bottom" id="editor">
<div dojoType="ToolbarContainer" id="toolbarLayout" layoutAlign="top">
<div dojoType="Toolbar" id="tb"></div>
</div>
<div dojoType="ContentPane" layoutAlign="client" id="drawing"></div>
</div>

<script type="text/javascript">
function img(name) {
	return dojo.uri.dojoUri("src/widget/templates/buttons/" + name + ".gif").toString();
}

function throbTest()
{
  var tb = new xdhToolbar();
  tb.initToolbar();
}

function xdhToolbar()
{
}

dojo.lang.extend(xdhToolbar, {
      initToolbar: function() {
      if (!dojo) {
        return;
      }
      var body = document.getElementById('root');
      var tc = dojo.widget.getWidgetById("toolbarLayout");
      var tb = dojo.widget.getWidgetById("tb");

      var bg = dojo.widget.createWidget("ToolbarButtonGroup", {
        name: "tools",
                                            defaultButton: "g2",
                                            preventDeselect: true
                                            });
      bg.addChild('g1');
      bg.addChild('no image here');
      bg.addChild('g2');
      var tbi = dojo.widget.ToolbarItem.make(img("delete"));
      bg.addChild(tbi);
      tb.addChild(bg);
    }
  });

dojo.addOnLoad(throbTest);
</script>
</body>
</html>

Change History (3)

comment:1 Changed 13 years ago by dylan

Component: General → Widgets
Milestone: → 0.5
Owner: changed from anonymous to bill

comment:2 Changed 12 years ago by bill

Component: Widgets → Dijit
Milestone: 0.9 → 1.0
Summary: Icon toolbar button can cause Firefox Throbber to start → Toolbar: Icon toolbar button can cause Firefox Throbber to start

comment:3 Changed 12 years ago by bill

Milestone: 1.0 → 0.9
Resolution: → fixed
Status: new → closed

The toolbar has been completely rewritten for 0.9 so this is no longer an issue.

Note: See TracTickets for help on using tickets.