accordion container does not support closable panes

[Becky Gibson]

According to the comments at the bottom of dijitlayoutStackContainer.js the extension supports title, selected and closable attributes for children of a stackContainer. This is currently not implemented for accordion panes - should it be?

[bill]

I'm ambivalent about adding this feature; users might destroy a pane when they just meant to open it. Perhaps the down-arrow icon on the pane title bar is a mistake, and it should just be a plain bar (like tab labels). Compare with the accordion on ​http://www.apple.com/mac/.

[Adam Peller]

I'm against adding this feature. I dont think it belongs in the accordion metaphor.

Yeah, I never understood the down-arrow thing.

Making destroy() work programmatically, however, is ok. (Someone could extend the UI to have a close if they want, I guess) That's covered here: #4642

[Adam Peller]

see also #4627

[bill]

OK, then I'm gonna close this ticket, since no one is really asking for the ability to close panes of an AccordionContainer? (yet).

[erotavlas]

Actually I was looking for this feature, similar to the way the filter is implemented in dojox.grid.EnhancedGrid?. Where user can add rules, and also remove them by closing the panes.

Since they all take 'ContentPanes?' why can't all of them i.e. accordioncontainer, titlepane, tabcontainer etc, accept the closable: true property? Why restrict it only to tab comntainers. The argument that users might destroy a pane would also apply to tab containers. Yet it was still implemented for those.

[dylan]

For Dojo 1, we would consider a pull request if you want to work on adding this to Dijit, per the contributing guidelines ( ​https://github.com/dojo/dijit/blob/master/CONTRIBUTING.md ). Keep in mind this is the first time someone has asked for this in 9 years, so it's just not the most common request, but if you want to do the leg work to add the code and write tests to support it, we'll review and land it.

Alternatively, we're currently working on the Dojo 2 AccordionPane? ( ​https://github.com/dojo/widgets/issues/14 ), so this would be as good of a time as any to request this feature.