#4661 closed enhancement (patchwelcome)
should BOM be included in build output, resource files?
| Reported by: | Adam Peller | Owned by: | Adam Peller |
|---|---|---|---|
| Priority: | low | Milestone: | 1.13 |
| Component: | BuildTools | Version: | 0.9 |
| Keywords: | unicode bom i18n needsreview | Cc: | James Burke |
| Blocked By: | Blocking: |
Description (last modified by )
If all supported browsers support the Unicode Byte Order Mark (BOM) then we should consider putting it at the top of our build output. This may make UTf-8 more explicit on the page and reduce problems for the user.
A separate issue -- if all the necessary tools support the BOM (#1660, #2440), should we use it in generated dojo.cldr files and any other non-ASCII files, like nls resources?
Change History (10)
comment:1 Changed 13 years ago by
| Cc: | James Burke added |
|---|---|
| Owner: | changed from James Burke to Adam Peller |
comment:2 Changed 13 years ago by
comment:3 Changed 12 years ago by
| Milestone: | → 1.2 |
|---|
comment:5 Changed 12 years ago by
comment:6 Changed 12 years ago by
comment:7 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Milestone: | 1.2 → future |
deferring this one again. Saxon doesn't seem to be outputting a BOM as advertised, and the output gets run through additional scripts of ours (like arrayLocale.js) which also need to preserve the DOM, and I'm having trouble getting JavaScript? (Rhino) + Java OutputStreams? to comply with that also.
comment:8 Changed 8 years ago by
| Keywords: | needsreview added |
|---|---|
| Priority: | high → low |
comment:9 Changed 4 years ago by
| Milestone: | future → 1.12 |
|---|---|
| Resolution: | → patchwelcome |
| Status: | new → closed |
Given that no one has shown interest in creating a patch in the past 7 years, I'm closing this as patchwelcome.
comment:10 Changed 4 years ago by
I wouldn't even welcome a patch. Things seems to be working well enough as-is, and adding a BOM could destabilize them.
Also, according to https://www.rfc-editor.org/rfc/rfc7159.txt:
Implementations MUST NOT add a byte order mark to the beginning of a JSON text.
So one could argue that for consistency we shouldn't do it for other files either (JS, CSS, HTML, etc.)
(In [11125]) refs #4661 - minor doc changes in html.js (can't start a line with 'returns') and adds in more verbose "description" vs "summary" in a few places.