Opened 12 years ago

Closed 12 years ago

#4655 closed defect (fixed)

Grid uses "static" for a variable name.

Reported by: James Burke Owned by: sjmiles
Priority: high Milestone: 1.0
Component: Dojox Version: 0.9
Keywords: Cc:
Blocked By: Blocking:

Description

"static" is a reserved "future" word for JavaScript? and right now Rhino chokes on it if used directly. blowery changed the references to static?, but I can see someone else using Grid might try to use the .static directly.

Not sure of the context and how it is used, but it might be good to change this variable to another name if possible, to avoid issues in Rhino (both in builds and as a runtime environment).

Change History (3)

comment:1 Changed 12 years ago by Ben Lowery

yeah, this is going to trip people up if they try to instantiate the static editor directly and use a build. i'm not familiar with the typical usage pattern for the grid editor's, so it may be a non-issue (do you instantiate a static editor directly or is it a by product of some configuration flag?).

comment:2 Changed 12 years ago by Tom Trenka

Owner: changed from Tom Trenka to sjmiles

Yeah, its a good catch, I'll reassign to sjmiles.

comment:3 Changed 12 years ago by sjmiles

Resolution: fixed
Status: newclosed

Changed 'static' to 'alwaysOn' in r10785.

Note: See TracTickets for help on using tickets.