ComboBoxMixin: two server transfers

[ptbrunet]

From Mark Hays...

In ComboBoxMixin in ComboBox.js there is

setDisplayedValue:function(/*String*/ value){

this._lastDisplayedValue = value; this.setValue(value, true);

},

...

case dojo.keys.ESCAPE:

...

if(this._lastDisplayedValue != this.getDisplayedValue()){

this.setValue(this._lastValueReported); this.setDisplayedValue(this._lastDisplayedValue); dojo.stopEvent(evt);

}else{

this.setValue(this.getValue());

}

Do you absolutely need to call both setValue and setDisplayedValue in the escape code? In FilteringSelect, this causes two simultaneous queries to the server which will compete to set the corresponding values. You only need one of the functions to make both assignments.

[ptbrunet]

I sent a patch to Mark Hays. His response:

_lastDisplayedValue doesn't seem initialized when you first load a FilteringSelect so your patch fails when you click inside a FilteringSelect and escape, which unexpectedly blanks the input. Make sure you set _lastDisplayedValue somewhere in FilteringSelect and test FilteringSelect.

I fixed that and sent him another patch for review.

[Adam Peller]

it might be helpful if the patches were simply attached to this ticket

[ptbrunet]

Patch attached.

[Becky Gibson]

(In [10872]) fixes #4633. Remove extra call to setValue() in escape key handling to prevent extra call to server. (commit for ptbrunet - IBM CLA)