#4633 closed defect (fixed)
ComboBoxMixin: two server transfers
Reported by: | ptbrunet | Owned by: | ptbrunet |
---|---|---|---|
Priority: | high | Milestone: | 1.0 |
Component: | Dijit - Form | Version: | 0.9 |
Keywords: | Cc: | brunet@… | |
Blocked By: | Blocking: |
Description
From Mark Hays...
In ComboBoxMixin in ComboBox.js there is
setDisplayedValue:function(/*String*/ value){
this._lastDisplayedValue = value; this.setValue(value, true);
},
...
case dojo.keys.ESCAPE:
...
if(this._lastDisplayedValue != this.getDisplayedValue()){
this.setValue(this._lastValueReported); this.setDisplayedValue(this._lastDisplayedValue); dojo.stopEvent(evt);
}else{
this.setValue(this.getValue());
}
Do you absolutely need to call both setValue and setDisplayedValue in the escape code? In FilteringSelect, this causes two simultaneous queries to the server which will compete to set the corresponding values. You only need one of the functions to make both assignments.
Attachments (1)
Change History (7)
comment:1 Changed 12 years ago by
Summary: | ComboBoxMixin: two sever transfers → ComboBoxMixin: two server transfers |
---|
comment:2 Changed 12 years ago by
comment:3 Changed 12 years ago by
it might be helpful if the patches were simply attached to this ticket
Changed 12 years ago by
Attachment: | 4633a.patch added |
---|
comment:5 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 Changed 9 years ago by
Component: | Dijit → Dijit - Form |
---|
I sent a patch to Mark Hays. His response:
I fixed that and sent him another patch for review.