Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4612 closed defect (fixed)

doc parser doesn't understand dojo.mixin()

Reported by: dante Owned by: Neil Roberts
Priority: high Milestone: 1.0
Component: Doc parser Version: 0.9
Keywords: Cc: alex
Blocked By: Blocking:

Description (last modified by dante)

in trunk/dojo/_base/array.js, line 14:

{{{ dojo.mixin(dojo, {

indexOf: function( /*Array*/ array,

/*Object*/ value,

... etc

}}}

creates the various dojo.forEach .indexOf - doc parser is not finding these summaries (or at least not placing them into the 'dojo' object)

only base's complicated closure and excessive use of aliases (var d = dojo) affects this. should we document the dojo core API all externally? (on the premise it should not be changing anyway, so the whole "edit an extra file" issue is moot?)

Change History (6)

comment:1 Changed 12 years ago by dante

Description: modified (diff)

should _not_ be changing.

comment:2 Changed 12 years ago by Neil Roberts

Resolution: fixed
Status: newclosed

(In [10763]) Fixes #4612. removeSwallowedMixins function added. getLocalVariableNames function added. Issue explained in ticket.

comment:3 Changed 12 years ago by Neil Roberts

Okay, so the parser basically handles this situation where you might have a function declaration inside of another function declaration, or inside of a mixin, etc.

We need to make sure that mixins that work on external variables can work just fine. Code was updated so that we can take the swallowed functions, and then remove any of them that are truly swallowed inside of a function in the format (function(){})();

comment:4 Changed 12 years ago by Neil Roberts

(In [10764]) Refs #4612. Rename mixins set using internal vars that get translated to external vars (eg var d = dojo)

comment:5 Changed 12 years ago by Neil Roberts

(In [10766]) Refs #4612. Lines can't start with keywords

comment:6 Changed 12 years ago by Neil Roberts

(In [10768]) Refs #4612. Make sure that mixins on this don't slip through, and that empty swallowed objects aren't added

Note: See TracTickets for help on using tickets.