Opened 12 years ago

Closed 12 years ago

#4603 closed defect (fixed)

Add docs and cleanup code of dojox.image

Reported by: sos Owned by: dante
Priority: high Milestone: 1.0
Component: Dojox Version: 0.9
Keywords: dojox.image Cc:
Blocked By: Blocking:

Description

The dojox.image widgets need better inline docs and code cleanup. Also, amalgamating multiple icons into a single image will reduce the number of remote requests for images.

Attachments (3)

dojox.image-docs_cleanup.patch (67.8 KB) - added by sos 12 years ago.
Patch to add inline docs and code cleanup
navBtns.gif (1.3 KB) - added by sos 12 years ago.
Icon file to go with the patch
dojox.image-thumb_sync.patch (791 bytes) - added by sos 12 years ago.
Fixes bug where thumnail images do not stay in sync with main image in Gallery

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by sos

Patch to add inline docs and code cleanup

Changed 12 years ago by sos

Attachment: navBtns.gif added

Icon file to go with the patch

comment:1 Changed 12 years ago by sos

I attached a patch file that adds code cleanup and many inline docs to the dojox.image files. I've also attached a new icon .gif file, with multiple icons contained in it. It is to go in the dojox/image/resources/image folder.

comment:2 Changed 12 years ago by dante

Resolution: fixed
Status: newclosed

(In [10683]) fixes #4603 - big cleanup and looks like some new features in dojox.image project (thanks to shane o'sullivan. cla)

comment:3 Changed 12 years ago by sos

Resolution: fixed
Status: closedreopened

navBtns.gif was placed in the wrong folder, resources instead of resources/images

comment:4 Changed 12 years ago by dante

Resolution: fixed
Status: reopenedclosed

(In [10700]) fixes #4603 - again - put the image in the wrong spot.

Changed 12 years ago by sos

Fixes bug where thumnail images do not stay in sync with main image in Gallery

comment:5 Changed 12 years ago by sos

Resolution: fixed
Status: closedreopened

There is an issue arising from the initial patch, where the thumbnail images no longer stay in sync with the slideshow images. The patch dojox.image-thumb_sync.patch fixes this.

comment:6 Changed 12 years ago by dante

Resolution: fixed
Status: reopenedclosed

(In [10718]) fixes #4603 - again - small var mismatch causing issues. patch from shane o'sullivan, CLA.

Note: See TracTickets for help on using tickets.