Opened 14 years ago

Closed 14 years ago

Last modified 5 years ago

#46 closed defect (fixed)

Subwidgets appear in type-order not order in which they are listed in HTML

Reported by: sjmiles@… Owned by: Dylan
Priority: blocker Milestone: 1.10
Component: Widgets Version: 0.0
Keywords: Cc: Dylan
Blocked By: Blocking:

Description (last modified by bill)

[edited] quote from Alex on IRC discussion:

slightlyoff: So here's what's happening. Normally, widgets are constructed and then the nodes they are constructed from are *replaced* (which the parent node is). This means that the child nodes are then added to the parent without being node replacements. So they just get added in whatever order the parser encounters them and since they're getting put into type-specific buckets...

Attachments (2)

ticket46.patch (4.5 KB) - added by dylan 14 years ago.
Potential patch, need a testcase…
test_46.html (769 bytes) - added by alex 14 years ago.
testcase for #46

Download all attachments as: .zip

Change History (13)

comment:1 Changed 14 years ago by anonymous

Cc: Dylan added

comment:2 Changed 14 years ago by alex

Milestone: 0.1beta

comment:3 Changed 14 years ago by sjmiles@…

Priority: normalhighest

IMO this is a 0.1 release blocker.

comment:4 Changed 14 years ago by anonymous

severity: normalblocker

comment:5 Changed 14 years ago by schontz@…

Milestone: 0.1beta0.1release
Version: 0.0

comment:6 Changed 14 years ago by alex

Owner: changed from Alex to Dylan

Changed 14 years ago by dylan

Attachment: ticket46.patch added

Potential patch, need a testcase...

Changed 14 years ago by alex

Attachment: test_46.html added

testcase for #46

comment:7 Changed 14 years ago by alex

Resolution: fixed
Status: newclosed

(In [1256]) this is a reworked version of Dylan's patch. it fixes #46

comment:8 Changed 12 years ago by (none)

Milestone: 0.1release

Milestone 0.1release deleted

comment:9 Changed 5 years ago by Kris Zyp <kriszyp@…>

In 7eaf98330aacf588d790aa9bc3b6a0850dbfc6e3/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:10 Changed 5 years ago by bill

Description: modified (diff)
Milestone: 1.10

comment:11 Changed 5 years ago by Kris Zyp

This was a reference to the github pull request #46 (I guess I should have used (#pr) instead of refs #pr. I didn't really rewrite the foundation of the templating engine just now :).

Note: See TracTickets for help on using tickets.