Opened 13 years ago
Closed 13 years ago
#4558 closed enhancement (wontfix)
dijit.MenuItem including a hardcoded reference to the theme
Reported by: | guest | Owned by: | |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | Dijit | Version: | 0.9 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The MenuItem? includes a couple of lines of code that are referring to the theme through strings:
dojo.addClass(this.domNode, 'dijitMenuItemHover');
dojo.removeClass(this.domNode, 'dijitMenuItemHover');
It would be nice to make them dependent from the baseClass in order to foster a better widgets extendability.
Paolo
Note: See
TracTickets for help on using
tickets.
There's no hardcoded reference to the theme. The theme are "tundra", "soria", etc. But yes, the CSS class names are hardcoded, and for dijit this was done intentionally for all the widgets, since we expect users to affect styles by putting a class on an ancestor node, typically
The "baseClass" variable is meant to be an internal thing, not something accessible to dijit users.